Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Animations are broken for SVG sub-elements if jQuery is present #10024

Closed
jonrimmer opened this issue Nov 12, 2014 · 3 comments
Closed

Animations are broken for SVG sub-elements if jQuery is present #10024

jonrimmer opened this issue Nov 12, 2014 · 3 comments
Assignees
@caitp
Labels
component: ngAnimate severity: broken expected use type: bug
Milestone
1.3.6

Comments

@jonrimmer
Copy link

If jQuery is present, then Angular animations on SVG sub-elements do not work, as jQuery does not support adding and removing classes from them. It would be helpful if $animate always used jqlite to perform class manipulation, rather than deferring to jQuery.
@caitp caitp added this to the 1.3.4 milestone Nov 12, 2014
@caitp caitp self-assigned this Nov 12, 2014
@caitp
Copy link
Contributor

caitp commented Nov 12, 2014

will look at fixing this today, it should be just a small refactoring...

@lgalfaso lgalfaso modified the milestones: 1.3.4, 1.3.5 Nov 25, 2014
@pkozlowski-opensource pkozlowski-opensource modified the milestones: 1.3.5, 1.3.6 Dec 1, 2014
@caitp
Copy link
Contributor

caitp commented Dec 3, 2014

so the reason this is taking so long is, i'm having problems writing a test which fails --- there are cases where jQuery apis are used to add classes in ngAnimate, but I am having trouble writing tests to verify that they work.

I'll give it another go as I've been mostly out of commission for the past week.

caitp added a commit to caitp/angular.js that referenced this issue Dec 4, 2014
@caitp
fix(ngAnimate): do not use jQuery class API
6c720da 
jQeury's class API causes problems with SVG elements --- using jqLite in all cases
prevents issues.

Closes angular#10024
@caitp caitp mentioned this issue Dec 4, 2014
Closed
caitp added a commit to caitp/angular.js that referenced this issue Dec 4, 2014
@caitp
fix(ngAnimate): do not use jQuery class API
ffc6920 
jQeury's class API causes problems with SVG elements --- using jqLite in all cases
prevents issues.

Closes angular#10024
caitp added a commit to caitp/angular.js that referenced this issue Dec 4, 2014
@caitp
fix(ngAnimate): do not use jQuery class API
0656ac9 
jQeury's class API causes problems with SVG elements --- using jqLite in all cases
prevents issues.

Closes angular#10024
@caitp caitp closed this as completed in 40a537c Dec 4, 2014
@jonrimmer
Copy link
Author

Hooray! 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@caitp caitp

Labels
component: ngAnimate severity: broken expected use type: bug
Projects
None yet
Milestone
1.3.6
Development

Successfully merging a pull request may close this issue.

fix(ngAnimate): do not use jQuery class API caitp/angular.js
4 participants
@jonrimmer @lgalfaso @pkozlowski-opensource @caitp