This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): do not use jQuery class API #10329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
jQeury's class API causes problems with SVG elements --- using jqLite in all cases prevents issues. Closes angular#10024
This makes it easy to use jqLite's nicer class API (compared to jQuery) in modules like ngAnimate.
| @@ -473,11 +473,12 @@ angular.module('ngAnimate', ['ng']) | |||
| function isMatchingElement(elm1, elm2) { | |||
| return extractElementNode(elm1) == extractElementNode(elm2); | |||
| } | |||
|
|
|||
| var $$jqLite; | |||
There was a problem hiding this comment.
PTAL --- I've added a commit which exposes jqLite via a private service.
Unfortunately, because of the structure of ngAnimate, not every function has access to it. I found it easier to just put a variable here, but I don't see why these functions need to be outside of the decorator, so it's easy to move them too.
What would you prefer?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQeury's class API causes problems with SVG elements --- using jqLite in all cases
prevents issues.
/cc @matsko please review
Closes #10024