Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

bug(ngAria): Use of ng-true-value and ng-false-value not updating aria-checked #10389

Closed
marcysutton opened this issue Dec 9, 2014 · 0 comments
Closed

bug(ngAria): Use of ng-true-value and ng-false-value not updating aria-checked #10389

marcysutton opened this issue Dec 9, 2014 · 0 comments
Assignees
@Narretz
Labels
component: forms component: ngAria frequency: high severity: broken expected use type: bug
Milestone
1.3.x - superlumi...

Comments

@marcysutton
Copy link
Contributor

Checkbox components using ng-true-value and ng-false-value are not computing the correct aria-checked value.

See this thread from Angular Material: angular/material#882 (comment)

Example code:

<md-switch ng-model="data.cb2" aria-label="Switch 2" ng-true-value="'yup'" 
ng-false-value="'nope'" role="checkbox" tabindex="0" 
aria-checked="true" aria-invalid="false">
</md-switch>

When the checkbox is toggled to the off position using these attributes, the aria-checked property is set to true. It should be false.
@Narretz Narretz added this to the 1.3.x milestone Dec 9, 2014
@Narretz Narretz self-assigned this Feb 8, 2015
Narretz added a commit to Narretz/angular.js that referenced this issue Feb 8, 2015
@Narretz
fix(ngAria): correctly set "checkd" attr for checkboxes and radios
55ac2e6 
Make sure the checked attribute is set correctly for:
- checkboxes with string and integer models using ngTrueValue /
ngFalseValue
- radios with integer models
- radios with boolean models using ngValue

Fixes angular#10389
Fixes angular#10212
Narretz added a commit to Narretz/angular.js that referenced this issue Feb 8, 2015
@Narretz
fix(ngAria): correctly set "checked" attr for checkboxes and radios
5aaaa87 
Make sure the checked attribute is set correctly for:
- checkboxes with string and integer models using ngTrueValue /
ngFalseValue
- radios with integer models
- radios with boolean models using ngValue

Fixes angular#10389
Fixes angular#10212
Narretz added a commit to Narretz/angular.js that referenced this issue Feb 8, 2015
@Narretz
fix(ngAria): correctly set "checked" attr for checkboxes and radios
cbda8fa 
Make sure the checked attribute is set correctly for:
- checkboxes with string and integer models using ngTrueValue /
ngFalseValue
- radios with integer models
- radios with boolean models using ngValue

Fixes angular#10389
Fixes angular#10212
@Narretz Narretz mentioned this issue Feb 8, 2015
Closed
Narretz added a commit to Narretz/angular.js that referenced this issue Feb 9, 2015
@Narretz
fix(ngAria): correctly set "checked" attr for checkboxes and radios
c1cb160 
Make sure the checked attribute is set correctly for:
- checkboxes with string and integer models using ngTrueValue /
ngFalseValue
- radios with integer models
- radios with boolean models using ngValue

Fixes angular#10389
Fixes angular#10212
Narretz added a commit that referenced this issue Feb 10, 2015
@Narretz
fix(ngAria): correctly set "checked" attr for checkboxes and radios
944c150 
Make sure the checked attribute is set correctly for:
- checkboxes with string and integer models using ngTrueValue /
ngFalseValue
- radios with integer models
- radios with boolean models using ngValue

Fixes #10389
Fixes #10212
@kkirsche kkirsche mentioned this issue Feb 25, 2015
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Narretz Narretz

Labels
component: forms component: ngAria frequency: high severity: broken expected use type: bug
Projects
None yet
Milestone
1.3.x - superluminal-nudge
Development

Successfully merging a pull request may close this issue.

fix(ngAria): correctly set "checked" attr for checkboxes and radios Narretz/angular.js
2 participants
@marcysutton @Narretz