This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(API Reference): Corrected two typos - two missing commas #10447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the ngAnimate section, there were two commas missing from two sentences. This is inconsistent with the grammar used in the rest of the API documentation and made the document (slightly) more difficult to read. The two sentences are shown below, with the new commas added:
1. "Once defined, the animation can be triggered"
^
comma added
2. "Once registered, the animation can be triggered"
^
comma added
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
LGTM -- just make sure to get that CLA signed alright? |
|
I have signed the CLA. |
|
CLAs look good, thanks! |
caitp
pushed a commit
that referenced
this pull request
Dec 14, 2014
In the ngAnimate section, there were two commas missing from two sentences. This is inconsistent with the grammar used in the rest of the API documentation and made the document (slightly) more difficult to read. The two sentences are shown below, with the new commas added:
1. "Once defined, the animation can be triggered"
^
comma added
2. "Once registered, the animation can be triggered"
^
comma added
Closes #10447
caitp
added a commit
to caitp/angular.js
that referenced
this pull request
Dec 16, 2014
…expression Minor improvement to ng-click directive from ngAria. Now, if bindings are updated during the click handler, the DOM will be updated as well. Additionally, the $event object is passed in to the expression via locals, as is done for core event directives. Closes angular#10442 Closes angular#10443 Closes angular#10447
caitp
added a commit
that referenced
this pull request
Dec 16, 2014
…expression Minor improvement to ng-click directive from ngAria. Now, if bindings are updated during the click handler, the DOM will be updated as well. Additionally, the $event object is passed in to the expression via locals, as is done for core event directives. Closes #10442 Closes #10443 Closes #10447
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ngAnimate section, there were two commas missing from two sentences. This is inconsistent with the grammar used in the rest of the API documentation and made the document (slightly) more difficult to read. The two sentences are shown below, before and after fix:
BEFORE: "Once defined the animation can be triggered"
AFTER: "Once defined, the animation can be triggered"
BEFORE: "Once registered the animation can be triggered"
AFTER: "Once registered, the animation can be triggered"