fix(ngAria): trigger digest on ng-click via keypress, pass $event to expression #10443
Conversation
|
CLAs look good, thanks! |
|
This does not fix the ngDblClick issue, that seems harder to emulate via keypress :< @gkalpak / @marcysutton could you review? |
|
I'm unable to review until Tuesday. But I'll dive in then if it's still unresolved!
|
| compile: function(elem, attr) { | ||
| var fn = $parse(attr.ngClick, /* interceptorFn */ null, /* expensiveChecks */ true); | ||
| return function(scope, elem) { | ||
| if ($aria.config('tabindex') && !elem.attr('tabindex')) { |
There was a problem hiding this comment.
Would it be safe to move this into compile ?
There was a problem hiding this comment.
There would be a problem with replace: true directives, which has been reported for other places where we do this, like ngModel. It's a trade-off, perf vs correctness
|
Other than a couple of minor comments, it LGTM. 👍 at BrowserStack |
…expression Minor improvement to ng-click directive from ngAria. Now, if bindings are updated during the click handler, the DOM will be updated as well. Additionally, the $event object is passed in to the expression via locals, as is done for core event directives. Closes angular#10442 Closes angular#10443 Closes angular#10447
Minor improvement to ng-click directive from ngAria. Now, if bindings are updated
during the click handler, the DOM will be updated as well. Additionally, the $event
object is passed in to the expression via locals, as is done for core event directives.
Closes #10442