ng-controller="SomeController as ctrl" not working

[redmagic]

Hi,

It seems the controllerAs directive no longer sets its own instance on the scope with the alias.

Please check this in http://plnkr.co/edit/4nQzmmIhBH2OeDTNW2md?p=preview

[pkozlowski-opensource]

Yes, this is a breaking change in 1.3.x - you can no longer return arbitrary objects from a controller's constructor function. This would work: http://plnkr.co/edit/nZBRQtTPswTP7kD9cuAC?p=preview

BTW: I find it strange that you are mixing both access to the raw $scope with the controller as syntax - IMO it is easier / more consistent to commit to one of those paradigms.

[caitp]

We could potentially fix it to reinstall isolate scope bindings if a value is returned from the constructor, though, at some performance cost.

[caitp]

My patch for 1.4 sort of makes it slightly easier to do that, so it might be something we could look at doing in a few months

[redmagic]

Thanks for the clarification.

In the angular docs and the google coding guide methods are still added to a controller through it's prototype though.

Adding methods on this would make inheritance of controllers more difficult wouldn't it?

I hope this gets reverted or improved. I would like my controllers to be instances with methods on their prototype.

@pkozlowski-opensource I mixed styles because the plunker was a quick copy.

[pkozlowski-opensource]

@redmagic nothing stops you from using prototypes: http://plnkr.co/edit/08CrGBjUMfchLtlAQtWj?p=preview

[redmagic]

Hi,

I had not thought of that, thanks. So if we put an immediate function around it, it would be more or less like in 1.2.x...http://plnkr.co/edit/VEZIy30Fv9FtMRx6p59m?p=preview

The advantage being not to need a module system for namespacing.

Thanks for following along.

[caitp]

FWIW I've added a patch to work around this in #10502, since people report this as a bug so frequently.

The problem with this is, it depends on some stuff slated for 1.4, so if we land it at all, it won't be for another few months. It likely will also cause memory leaks and performance regressions :(