Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(orderBy): compare timestamps when sorting date objects #10516

Closed
wants to merge 1 commit into from
Closed

fix(orderBy): compare timestamps when sorting date objects #10516

wants to merge 1 commit into from
+14 −4

Conversation

pkozlowski-opensource
Copy link
Member

Fixes #10512

@googlebot
Copy link

CLAs look good, thanks!

@pkozlowski-opensource
Copy link
Member Author

@caitp would you mind taking a look at this one? I think that the regression was introduced as the tests were not good enough and I guess having valueOf taking priority over toString makes sense.

@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Dec 18, 2014
Closed
@caitp
Copy link
Contributor

caitp commented Dec 18, 2014

lgtm

@pkozlowski-opensource pkozlowski-opensource deleted the issue10512 branch December 19, 2014 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OrderBy filter doesn't work with dates (momentJS and native dates)
3 participants
@pkozlowski-opensource @googlebot @caitp