Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(orderBy): compare timestamps when sorting date objects #10516

Closed
wants to merge 1 commit into from
Closed

fix(orderBy): compare timestamps when sorting date objects #10516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/ng/filter/orderBy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,14 @@ function orderByFilter($parse) {

function objectToString(value) {
if (value === null) return 'null';
if (typeof value.toString === 'function') {
value = value.toString();
if (isPrimitive(value)) return value;
}
if (typeof value.valueOf === 'function') {
value = value.valueOf();
if (isPrimitive(value)) return value;
}
if (typeof value.toString === 'function') {
value = value.toString();
if (isPrimitive(value)) return value;
}
return '';
}

Expand Down
10 changes: 10 additions & 0 deletions test/ng/filter/orderBySpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,16 @@ describe('Filter: orderBy', function() {
{ a:new Date('01/01/2014'), b:3 }]);
});

it('should compare timestamps when sorting dates', function() {
expect(orderBy([
new Date('01/01/2015'),
new Date('01/01/2014')
])).toEqualData([
new Date('01/01/2014'),
new Date('01/01/2015')
]);
});


it('should use function', function() {
expect(
Expand Down