Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngAnimate doesn't cleanup correctly when on root Element #10527

Closed
Narretz opened this issue Dec 19, 2014 · 2 comments
Closed

ngAnimate doesn't cleanup correctly when on root Element #10527

Narretz opened this issue Dec 19, 2014 · 2 comments

Comments

@Narretz
Copy link
Contributor

Narretz commented Dec 19, 2014

When you have something like

<body ng-app="myApp"></body>

and do
$animate.addClass(body, 'abc');

the ng-animate class is not removed after the animation finishes. This is because cleanup has a special path if it's the root element: https://github.com/angular/angular.js/blob/master/src/ngAnimate/animate.js#L1512
(Simple) animations work anyway, so it looks like a minor thing - although the default path does a little more stuff.

@matsko
Copy link
Contributor

matsko commented Apr 10, 2015

@Narretz this is fixed in 1.4 as of now. We should fix this in 1.3 however.

@Narretz
Copy link
Contributor Author

Narretz commented Nov 30, 2015

1.3 is not worked on anymore.

@Narretz Narretz closed this as completed Nov 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants