angular.mock.$ExceptionHandlerProvider Provide mode logAndRethrow

[DavidSouther]

https://github.com/angular/angular.js/blob/master/src/ngMock/angular-mocks.js#L253

Currently, test exceptions can either log or rethrow. There are cases where the throw behavior is expected by the implementation, but it would also be nice to have a log available. In these situations, a logAndThrow behavior would ease having two different code flows.

[petebacondarwin]

You can easily achieve this via a decorator: http://plnkr.co/edit/OORm4yDYh2Gx1QoEvQt8

[caitp]

Actually, I think this would be good to have. It's ngMock so code size doesn't really matter, and there are a number of places where it's useful in core tests and worked around really awkwardly

[petebacondarwin]

Oh right! I didn't notice that it was angular-mocks. Fine by me.

This is an easy first PR if anyone is interested. Just add a new option to the mode and provide suitable tests (https://github.com/angular/angular.js/blob/master/test/ngMock/angular-mocksSpec.js#L589) and documentation (https://github.com/angular/angular.js/blob/master/src/ngMock/angular-mocks.js#L246).

[DavidSouther]

I'll take a shot at it :)

On Mon Dec 22 2014 at 4:54:39 AM Pete Bacon Darwin notifications@github.com
wrote:

Oh right! I didn't notice that it was angular-mocks. Fine by me.

This is an easy first PR if anyone is interested. Just add a new option to
the mode and provide suitable tests (
https://github.com/angular/angular.js/blob/master/test/ngMock/angular-mocksSpec.js#L589)
and documentation (
https://github.com/angular/angular.js/blob/master/src/ngMock/angular-mocks.js#L246
).

—
Reply to this email directly or view it on GitHub
#10540 (comment)
.

[petebacondarwin]

@DavidSouther - Great!

Please make sure that you have signed the CLA, associated it with your Github username and that your commit messages match our requirements.

Get in touch if you need any help.

[DavidSouther]

Uh... none of these module(function($exceptionHandlerProvider){}) tests are actually running.

[DavidSouther]

The module() calls did not have a corresponding inject(), so no assertions were executed. #10563 fixes that.

[DavidSouther]

For a larger conversation, does it make sense to combine logAndRethrow into rethrow? Personally, that was my expected behavior before reading the docs that the additional logic from $exceptionHandler in mocks would only add, not change, functionality.