ng-required overrides type=email initial validation in chrome #10698

tompi · 2015-01-09T13:45:07Z

It seems since 1.3.4, ngmodel set from controller, will not get ng-invalid initially if I use both type=email and ng-required in latest chrome. works fine in firefox, or with just required attribute.

Reproducable: always
Browsers: Chrome 39.0.2171.95 m
Operating system: Windows 7

Details in the plnkr:

http://plnkr.co/edit/1iphMDUloBtUQJ4vHxdz?p=preview

When a parser has the same name as a validator key, and a parse error occurs, set validity for parser name after setting validity for the validator key. Otherwise, the parse key is set, and then immediately afterwards the validator key is unset (because parse errors remove all other validations). Fixes angular#10698 Closes angular#10828

For $validate(), it is necessary to store the parseError state in the controller. Otherwise, if the parser name equals a validator key, $validate() will assume a parse error occured if the validator is invalid. Also, setting the validity for the parser now happens after setting validity for the validator key. Otherwise, the parse key is set, and then immediately afterwards the validator key is unset (because parse errors remove all other validations). Fixes angular#10698 Closes angular#10828

For $validate(), it is necessary to store the parseError state in the controller. Otherwise, if the parser name equals a validator key, $validate() will assume a parse error occured if the validator is invalid. Also, setting the validity for the parser now happens after setting validity for the validator key. Otherwise, the parse key is set, and then immediately afterwards the validator key is unset (because parse errors remove all other validations). Fixes angular#10698 Closes angular#10850

For $validate(), it is necessary to store the parseError state in the controller. Otherwise, if the parser name equals a validator key, $validate() will assume a parse error occured if the validator is invalid. Also, setting the validity for the parser now happens after setting validity for the validator key. Otherwise, the parse key is set, and then immediately afterwards the validator key is unset (because parse errors remove all other validations). Fixes #10698 Closes #10850 Closes #11046

For $validate(), it is necessary to store the parseError state in the controller. Otherwise, if the parser name equals a validator key, $validate() will assume a parse error occured if the validator is invalid. Also, setting the validity for the parser now happens after setting validity for the validator key. Otherwise, the parse key is set, and then immediately afterwards the validator key is unset (because parse errors remove all other validations). Fixes angular#10698 Closes angular#10850 Closes angular#11046

Narretz added component: forms type: bug severity: regression frequency: moderate severity: broken expected use labels Jan 15, 2015

Narretz added this to the 1.4.x milestone Jan 15, 2015

Narretz self-assigned this Jan 15, 2015

Narretz mentioned this issue Jan 23, 2015

fix(ngModel): fix issues when parserName is same as validator key #10850

Closed

petebacondarwin closed this as completed in 056a317 Feb 13, 2015

kkirsche mentioned this issue Feb 25, 2015

Update AngularJS to 1.3.14 cmar/rubyloco.com#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ng-required overrides type=email initial validation in chrome #10698

ng-required overrides type=email initial validation in chrome #10698

tompi commented Jan 9, 2015

ng-required overrides type=email initial validation in chrome #10698

ng-required overrides type=email initial validation in chrome #10698

Comments

tompi commented Jan 9, 2015