Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs: step 6 of tutorial use a href rather than an ng-href #10828

Closed
EthanLozano opened this issue Jan 21, 2015 · 4 comments
Closed

docs: step 6 of tutorial use a href rather than an ng-href #10828

EthanLozano opened this issue Jan 21, 2015 · 4 comments
Labels
type: docs
Milestone
Backlog - won't fix

Comments

@EthanLozano
Copy link

step_06.ngdoc uses a dynamically generated link with the href attribute rather than the ng-href attribute.
@EthanLozano
Copy link
Author

The Phonecat tutorial source code and tag needs to be changed first. So, I went ahead and created an issue for that repo.

@EthanLozano EthanLozano mentioned this issue Jan 21, 2015
Closed
@Narretz Narretz added this to the Backlog milestone Jan 23, 2015
Narretz added a commit to Narretz/angular.js that referenced this issue Jan 23, 2015
@Narretz
fix(ngModel): fix issues when parserName is same as validator key
c9e59b7 
When a parser has the same name as a validator key, and a parse error
occurs, set validity for parser name after setting validity for the
validator key.

Otherwise, the parse key is set, and then immediately afterwards the
validator key is unset (because parse errors remove all other
validations).

Fixes angular#10698
Closes angular#10828
Narretz added a commit to Narretz/angular.js that referenced this issue Jan 23, 2015
@Narretz
fix(ngModel): fix issues when parserName is same as validator key
bd1795e 
For $validate(), it is necessary to store the parseError state
in the controller. Otherwise, if the parser name equals a validator
key, $validate() will assume a parse error occured if the validator
is invalid.

Also, setting the validity for the parser now happens after setting
validity for the validator key. Otherwise, the parse key is set,
and then immediately afterwards the validator key is unset
(because parse errors remove all other validations).

Fixes angular#10698
Closes angular#10828
@Narretz Narretz mentioned this issue Jan 23, 2015
Closed
@dguzzo
Copy link
Contributor

dguzzo commented Jun 14, 2015

@Narretz hmm, not sure how #10850 being merged will fix the issue with the docs here; regardless of parsing, shouldn't the example in the tutorial still use ng-href for the dynamic link? I'm probably missing something.

@Narretz
Copy link
Contributor

Narretz commented Jun 14, 2015

It looks like I referenced the wrong issue to close.

@petebacondarwin
Copy link
Contributor

This is not really necessary as it is unlikely that the user will click on a link before Angular has had time to fill it correctly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: docs
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging a pull request may close this issue.

fix(ngModel): fix issues when parserName is same as validator key Narretz/angular.js
4 participants
@petebacondarwin @dguzzo @Narretz @EthanLozano