ngPluralize example has problem when a value >3 is deleted

[mrsoto]

In this page
https://code.angularjs.org/1.3.10/docs/api/ng/directive/ngPluralize

Change the number of peoples to 3 or more and then clear the field.

typing 3 and cleaning get -2 other peoples...

[caitp]

yeah, that's kind of weird --- @petebacondarwin do you think ngPluralize should support signed values by default? or maybe there's a better way

[gkalpak]

FWIW, I can't reproduce on Chrome/Firefox on Windows, but it sounds reasonable to (properly) handle negative values as 0.
On what browsers/platforms do you see this ?

[caitp]

you can see it in chrome and safari on a mac, i expect you can see it on windows too

[mrsoto]

I've the problem in Windows Chrome
El 22/01/2015 16:01, "⭐caitp⭐" notifications@github.com escribió:

you can see it in chrome and safari on a mac, i expect you can see it on
windows too

—
Reply to this email directly or view it on GitHub
#10836 (comment)
.

[mrsoto]

This example start assuming that blank is zero and this assumption remain
for 1 and 2 after the field is cleared but if you type 3 or more and then
clear the field got negative values.
El 22/01/2015 15:37, "⭐caitp⭐" notifications@github.com escribió:

yeah, that's kind of weird --- @petebacondarwin do you think ngPluralize
should support signed values by default? or maybe there's a better way

—
Reply to this email directly or view it on GitHub.

[gkalpak]

I can reproduce it with 4 or more but not 3. Weird...

[gkalpak]

I think the problem is that lastCount was assumed to always be numeric (thus assuming that isNaN(lastCount)===true means lastCount -> NaN (which isn't true)).

[Narretz]

✨ Don't forget to label / milestone everyone! ✨

[petebacondarwin]

+1 Narretz!