This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngPluralize): fix wrong text content when count is null/undefined #10841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
lastCount
was evaluated to an non-numeric value (e.g. "other") andcount
was evaluated toNaN
(e.g.null
/undefined
), the text contentwould be (wrongly) based on the previous template.
This commits makes sure the text content is updated correctly.
In order to customize the message shown upon
null
/undefined
one canspecify a
'NaN'
property on thewhen
exression object.Closes #10836