-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Regression: cannot extend headers in requestTransform fn #11438
Comments
I would argue that this is incorrect usage since the idea behind My vote would be to documenting it as a breaking change. |
If someone wants to modify headers it should be done via a header being a function. |
I guess it's pretty weird to use it that way, yes. |
Right, so my proposal is this:
How does it sound @Narretz ? |
We've had breaking change notes for very minor things, so we should definitely do it. I'm not sure a test is needed, but it can't hurt. |
Before 5da1256, it used to be possible to do this:
This is because the headersGetter used to re-use the argument instead of declaring a new one: 5da1256#diff-748e0a1e1a7db3458d5f95d59d7e16c9L71
/cc @pkozlowski-opensource
The text was updated successfully, but these errors were encountered: