Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngSelect + ngOptions performs deep equality check unnecessarily in certain scenarios #11447

Closed
booleanbetrayal opened this issue Mar 27, 2015 · 2 comments
Closed

ngSelect + ngOptions performs deep equality check unnecessarily in certain scenarios #11447

booleanbetrayal opened this issue Mar 27, 2015 · 2 comments
Labels
component: forms needs: investigation PRs plz! type: bug type: perf

Comments

@booleanbetrayal
Copy link
Contributor

Looks to be a result of #10893 which was first reported in #10869. Basically, the deep equality check should be avoided if operating in a context where object references are maintained.
This was referenced Mar 27, 2015
Closed
Closed
@mathemagica
Copy link

+1

@petebacondarwin
Copy link
Contributor

Closing in favour of #11448

petebacondarwin pushed a commit that referenced this issue Mar 30, 2015
@booleanbetrayal @petebacondarwin
perf(ngOptions): only perform deep equality check on ngModel if using…
171b9f7 
… track by

Closes #11448
Closes #11447
@ryanhart2 ryanhart2 mentioned this issue May 24, 2015
Closed
netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@booleanbetrayal @netman92
perf(ngOptions): only perform deep equality check on ngModel if using…
e41c524 
… track by

Closes angular#11448
Closes angular#11447
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: forms needs: investigation PRs plz! type: bug type: perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(ngOptions): only perform deep equality check on ngModel if using track by
3 participants
@petebacondarwin @booleanbetrayal @mathemagica