This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngMessageFormat): minified symbol and nested required expression #11592
+62
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirayuk
force-pushed
the
messageFormat_e2e_and_fix
branch
from
3124a61 to
89b8b43
Compare
Add an E2E test that works against the minified module to test that the minified build works correctly. Fix a bug where mustHaveExpression was passed through to submessages unchanged. Use of the messageFormat syntax automatically means that you are using an expression. Therefore, submessages should not be required to also have messages. This closes angular#11414
| @@ -5,11 +5,11 @@ | |||
| // This file is compiled with Closure compiler's ADVANCED_OPTIMIZATIONS flag! Be wary of using | |||
| // constructs incompatible with that mode. | |||
|
|
|||
| var $interpolateMinErr = angular['$interpolateMinErr']; | |||
| var $interpolateMinErr = window['angular']['$interpolateMinErr']; | |||
There was a problem hiding this comment.
This shouldn't be necessary, since normally the code would be wrapped into an IIFE and passed window.angular as an argument:
(function (window, angular, undefined) { ... })(window, window.angular);Any idea why it doesn't work ?
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Add an E2E test that works against the minified module to test that the minified build works correctly. Fix a bug where mustHaveExpression was passed through to submessages unchanged. Use of the messageFormat syntax automatically means that you are using an expression. Therefore, submessages should not be required to also have messages. Closes angular#11414 Closes angular#11592
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an E2E test that works against the minified module to test that the
minified build works correctly.
Fix a bug where mustHaveExpression was passed through to submessages
unchanged. Use of the messageFormat syntax automatically means that you
are using an expression. Therefore, submessages should not be required
to also have messages. This closes #11414