docs(i18n): expand the MessageFormat syntax documentation

[chirayuk]

No description provided.

[chirayuk]

@petebacondarwin—I also have a bugfix for MessageFormat that needs to go in this release. I also missed the bower publish/unpublish for this module that I'll be adding (also a separate PR.)

[petebacondarwin]

@chirayuk do you think we should deprecate ngPluralize in 1.5 and put it in its own separate module?

[chirayuk]

I hadn't done that because I had mistakenly assumed that ngPluralize allowed its embedded messages to contain HTML. Reading the docs and testing on plnkr.co shows that that is not the case.

So yes, we should definitely deprecate this for 1.5! Should I say something about it in the docs for 1.4 right now?

[petebacondarwin]

This looks great @chirayuk!
Apart from a few minor tweaks above it looks good. Feel free to fix up and merge.

[gkalpak]

dependant --> dependent ?

[chirayuk]

Good catch. Fixed.

[gkalpak]

I like this (I originally thought MessageFormat would be complex to use, but it turns out it is pretty much straight-forward). 👍 @chirayuk

Apart from the minor inline comments, I have a couple (not so minor ?) not-inline comments/questions/remarks:

1. The minified version of angular-messageFormat of the current snapshot seems to have issues (example). Using the non-minified version works fine.
   Without digging too deep, I think it is because the IIFE is invoked with window.Ga instead of window.angular. (Something related to the config of Closure compiler perhaps ?)
2. Elsewhere, the module file is referred to as angular-messageformat[.min].js (all lowercase), but it seems to be angular-messageFormat (capital F) now. I would suggest changing it to something lowercase (either angular-messageformat or angular-message-format) to avoid issues with OSes treating file names and casing in different/weird ways.
   In any case, the name should appear consistently (and correctly) across all docs.

_{@chirayuk, let me know if you would like me to open separate issues.}

[petebacondarwin]

@gkalpak - I think your first issue has just been fixed with #11592

[petebacondarwin]

LGTM

[petebacondarwin]

@gkalpak for your second point, I wonder if the capitalization of the module name is being changed by dgeni when generating that page...

[chirayuk]

@gkalpak—regarding your comments:

The minified version bug has been fixed in a PR with an E2E test for it. See PR 11592.

The casing—I fixed the only place it was inconsistently cased and made it part of this PR. However, that does not fix the problem because the stuff generated in the build/ tree contains lowercased references.

Would you file two issues for this—(1) casing should be changed to lowercase everywhere for consistency, (2) for me to create the bower repository and update scripts/bower/(un)publish.sh to use it so that this is published to bower as well. I would like to tackle those as separate issues. Thanks.

[chirayuk]

On bower repo/module file name casing: I'm going to go with bower-angular-message-format and angular-message-format.min.js. based on chatting with @IgorMinar and @btford. This avoid the issue of casing that might affect case insensitive filesystem and has better consistency with names in URLs (i.e. using the hyphen as the separator character.) Let me know if you have other thoughts.

[gkalpak]

@chirayuk, I see you have already opened the issues.
I too think that angular-message-format is the most consistent naming.

[chirayuk]

@gkalpak @petebacondarwin the rename to angular-message-format is complete. It's in sha 0d64f08 (was PR #11597). I'm going to merge this one in now.