This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(filterFilter): fix matching against null/undefined
#11617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
force-pushed
the
v1.3.x_filterFilter-fix-matching-null-undefined
branch
from
f978b63 to
2e574ec
Compare
gkalpak
added a commit
that referenced
this pull request
Apr 28, 2015
Included fixes:
* Do not convert `null`/`undefined` to strings for substring matching in
non-strict comparison mode. Prevents `null`/`undefined` from being matched
against e.g. 'u'.
* Let `null` (as a top-level filter expression) match "deeply" (as do booleans,
numbers and strings).
E.g. let `filterFilter(arr, null)` match an item like `{someProp: null}`.
Fixes #11573
Closes #11617
gkalpak
force-pushed
the
v1.3.x_filterFilter-fix-matching-null-undefined
branch
from
2e574ec to
9dd0fe3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included fixes:
null/undefinedto strings for substring matching in non-strict comparison mode.Prevents
null/undefinedfrom being matched against e.g. 'u'.null(as a top-level filter expression) match "deeply" (as do booleans, numbers and strings).E.g. let
filterFilter(arr, null)match an item like{someProp: null}.Fixes #11573
(Cherry-picked from b5002ab to fix regressions as described in #11445 (comment).)