Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Unable to use ! with the empty field value #11756

Closed
codebased opened this issue Apr 29, 2015 · 6 comments
Closed

Unable to use ! with the empty field value #11756

codebased opened this issue Apr 29, 2015 · 6 comments

Comments

@codebased
Copy link

With the previous version I could use "!" for filtering records where field has null or empty value.

example:

ng-repeat="category in vm.model.categories | filter: {parentId: '!'}"

After changing to the latest, it is breaking.

Any suggestion?

@petebacondarwin
Copy link
Contributor

This works for me with the latest on master: http://plnkr.co/edit/oURMfuBqYGBcMrXEyYsR?p=preview
and also with the latest release candidate: http://plnkr.co/edit/IAy2Eq6xTPRDpik6GSfw?p=preview

@gkalpak
Copy link
Member

gkalpak commented Apr 29, 2015

@codebased is probably referring to the 1.3.x branch.

There was a regression since 1.3.6, which has been fixed on the 1.4.x branch, but not on 1.3.x yet.
We have discussed (somewhere) that we should backport the fix (since it was a regression) and I have submitted PR #11617 against the 1.3.x branch (but it's not merged yet); hence it's still reproducible on 1.3.15.

@petebacondarwin, should I merge #11617 ?
I submitted the PR to make sure Travis is happy, but I am not sure if I should get a LGTM or not (since this is a backported fix).

@codebased
Copy link
Author

@gkalpak @petebacondarwin Yes it is "version": "1.3.15",

@petebacondarwin
Copy link
Contributor

LGTM

@gkalpak
Copy link
Member

gkalpak commented Apr 29, 2015

Hm... I just realized, @Narretz has already merged my PR since yesterday (9dd0fe3), so this should be fixed for 1.3.x as soon as v1.3.16 is out.

@Narretz
Copy link
Contributor

Narretz commented Apr 29, 2015

Yes, I merged it because it was a regression. Github should probably send out notifications when subscribed issues are closed ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants