This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
(bug) ngAnimate element.parent is not a function #11703
Milestone
Comments
@matsko, the issue appears to be that the ng-animate rewrite does not take into account text nodes. I've taken a stab at fixing it in my PR, but it appears I've not completely wrapped my head around ng-animate internals. Care to comment? |
matsko
added a commit
to matsko/angular.js
that referenced
this issue
May 4, 2015
With the large refactor in 1.4.0-rc.0, the detection code failed to filter out text nodes from animating. This fix ensures that now properly happens. Closes angular#11703
matsko
added a commit
to matsko/angular.js
that referenced
this issue
May 5, 2015
With the large refactor in 1.4.0-rc.0, the detection code failed to filter out text nodes from animating. This fix ensures that now properly happens. Closes angular#11703
netman92
pushed a commit
to netman92/angular.js
that referenced
this issue
Aug 8, 2015
With the large refactor in 1.4.0-rc.0, the detection code failed to filter out text nodes from animating. This fix ensures that now properly happens. Closes angular#11703
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm using version 1.4.0-rc.0 of ngAnimate and there's an issue when
$animate.leave
is called with aTextNode
as an argument. Here's the stack trace:I've managed to isolate the issue in a Plunker and it appears to be caused by this line which returns a boolean (usually
false
) to thequeueAnimation
function. It then tries to call theparent
method and throws the error.In the Plunker posted above, the H1's text gets passed to the
leave
method by thetranslate
directive. If the text is wrapped in another element, the error is gone. For example:EDIT: Here's a better isolated example of the same issue: https://jsfiddle.net/pLvmf9qg/
The text was updated successfully, but these errors were encountered: