Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

bug: ngAnimate - ngSwitch not working #11769

Closed
karol-f opened this issue Apr 30, 2015 · 1 comment
Closed

bug: ngAnimate - ngSwitch not working #11769

karol-f opened this issue Apr 30, 2015 · 1 comment
Assignees
@matsko
Labels
component: ngAnimate severity: regression
Milestone
1.4.0-rc.2

Comments

@karol-f
Copy link

karol-f commented Apr 30, 2015

Overview of issue

Animation of ngSwitch stopped working in 1.4

Version

1.4 (e.g. RC0, RC1)

Reproduce

Not working (example in documentation of current 1.4 version)

https://docs.angularjs.org/api/ng/directive/ngSwitch#example

Working (example in documentation of current 1.3 version)

https://code.angularjs.org/1.3.15/docs/api/ng/directive/ngSwitch#example

Expected

Expecting ngSwitch animation working when ngAnimate module is loaded.
@petebacondarwin petebacondarwin added this to the 1.4.0-rc.2 milestone May 1, 2015
matsko added a commit to matsko/angular.js that referenced this issue May 5, 2015
@matsko
fix(ngAnimate): ensure that the temporary CSS classes are applied bef…
781e5d7 
…ore detection

Prior to 1.4 the `ng-animate` CSS class was applied before the CSS
getComputedStyle detection was issued. This was lost in the 1.4
refactor, however, this patch restores the functionality.

Closes angular#11769
@matsko matsko mentioned this issue May 5, 2015
Closed
@matsko
Copy link
Contributor

matsko commented May 5, 2015

Thank you for finding this issue. This is pretty important bug. There is a PR ready which fixes it #11804.

@matsko matsko closed this as completed in f7e9ff1 May 7, 2015
netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@matsko @netman92
fix(ngAnimate): ensure that the temporary CSS classes are applied bef…
e078dc2 
…ore detection

Prior to 1.4 the `ng-animate` CSS class was applied before the CSS
getComputedStyle detection was issued. This was lost in the 1.4
refactor, however, this patch restores the functionality.

Closes angular#11769
Closes angular#11804
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
component: ngAnimate severity: regression
Projects
None yet
Milestone
1.4.0-rc.2
Development

Successfully merging a pull request may close this issue.

fix(ngAnimate): ensure that the temporary CSS classes are applied before detection matsko/angular.js
3 participants
@petebacondarwin @matsko @karol-f