-
Notifications
You must be signed in to change notification settings - Fork 27.4k
ngAnimate makes IE11 grind to a halt #11791
Comments
Here it is again with 1000 elements The example on 1.4.0-rc.1 takes a lot longer to show when compared to 1.3.15. |
Can confirm that there's a significant delay. |
It also happens in the latest snapshot. Interestingly, it doesn't regress if you combine an angular version from before the refactoring (say 1.4.0-beta.6) with an animate version from after the refactoring. |
@Narretz at least So probably not regressing due to the module not being loaded successfully? |
… buffered IE11 (and maybe some other browsers) do not optimize multiple calls to rAF. This code makes that happen internally within the $$rAF service before the next frame kicks in. Closes angular#11791
… buffered IE11 (and maybe some other browsers) do not optimize multiple calls to rAF. This code makes that happen internally within the $$rAF service before the next frame kicks in. Closes angular#11791
… buffered IE11 (and maybe some other browsers) do not optimize multiple calls to rAF. This code makes that happen internally within the $$rAF service before the next frame kicks in. Closes angular#11791
OK there is now a fix for this: Existing (broken) version: Fixed version: |
… buffered IE11 (and maybe some other browsers) do not optimize multiple calls to rAF. This code makes that happen internally within the $$rAF service before the next frame kicks in. Closes angular#11791
… buffered IE11 (and maybe some other browsers) do not optimize multiple calls to rAF. This code makes that happen internally within the $$rAF service before the next frame kicks in. Closes angular#11791
… buffered IE11 (and maybe some other browsers) do not optimize multiple calls to rAF. This code makes that happen internally within the $$rAF service before the next frame kicks in. Closes angular#11791
… buffered IE11 (and maybe some other browsers) do not optimize multiple calls to rAF. This code makes that happen internally within the $$rAF service before the next frame kicks in. Closes #11791
Was this submitted to MS? I couldn't find it so I created my own report: We should be good Web citizens, though, and report such issues to browser vendors. If they don't know about it, they can't fix it! |
… buffered IE11 (and maybe some other browsers) do not optimize multiple calls to rAF. This code makes that happen internally within the $$rAF service before the next frame kicks in. Closes angular#11791
This jsfiddle (http://jsfiddle.net/oga2z7bb/3/) uses ng-repeat to render 10000 numbers. This jsfiddle (http://jsfiddle.net/oga2z7bb/4/) does the same thing but includes ngAnimate.
Both examples work fine in Chrome & Firefox. The first example also works in IE11, however if you open http://jsfiddle.net/oga2z7bb/4/ in IE11 your browser should stop responding. I've profiled (with 1 000 numbers instead of 10 000) this and it seems that 99% of the time is spent in
window.requestAnimationFrame()
.I use ng-repeat to render a calendar in my app. With IE11 it is effectively unusable unless I do some browser sniffing and not load ngAnimate when IE is detected.
The text was updated successfully, but these errors were encountered: