You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
So instead of adding a new element at the beginning of parent, I add them after the last item on parent.
That worked good, but after I updated to Angular 1.4.x, it says that what I pass as the third parameter parent[0].lastChild doesn't have the after method. That suggested to me that I needed to wrap that element into angular.element:
Prior to this fix the $animate.enter() and $animate.move() events caused
an error when a parent or after element was provided that was not
already wrapped as a jqLite element. This patch ensures that both
wrapped and unwrapped DOM nodes are allowed.
Closesangular#11848
Prior to this fix the $animate.enter() and $animate.move() events caused
an error when a parent or after element was provided that was not
already wrapped as a jqLite element. This patch ensures that both
wrapped and unwrapped DOM nodes are allowed.
Closesangular#11848
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I have been doing
$animate.enter()
for a while in Angular1.3.x
in the following way:So instead of adding a new
element
at the beginning ofparent
, I add them after the last item onparent
.That worked good, but after I updated to Angular
1.4.x
, it says that what I pass as the third parameterparent[0].lastChild
doesn't have theafter
method. That suggested to me that I needed to wrap that element intoangular.element
:And that did work. The thing is, I tried to replicate this issue on a plunker and it didn't work either in 1.3.x if I don't wrap the third parameter.
So my question is: Having to wrap the third parameter with
angular.element
was always needed? Or maybe with the whole refactor it needs it now?It surely fixed it to work with
1.3.x
as well but it feels weird now.There is a plunker
Maybe I am doing it wrong, but it worked for me in the past when it was just
after.after
.The text was updated successfully, but these errors were encountered: