This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animateCss): ensure that custom durations do not confuse the gcs cache #11852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -742,6 +742,9 @@ var $AnimateCssProvider = ['$animateProvider', function($animateProvider) { | |||
| applyAnimationClasses(element, options); | |||
| applyAnimationStyles(element, options); | |||
|
|
|||
| // we increment the counter so that if the same element is animated | |||
| // then the existing cache will not apply to it | |||
|
|
|||
There was a problem hiding this comment.
I don't understand the context of this comment. Where is the counter that is being incremented?
There was a problem hiding this comment.
sorry that is dead code from a previous fix I had in mind.
matsko
force-pushed
the
animate_css_cache_break
branch
from
34c4426 to
8576671
Compare
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11723