This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animateCss): ensure that detection cache is flushed after animation is closed #11805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -765,6 +769,12 @@ var $AnimateCssProvider = ['$animateProvider', function($animateProvider) { | |||
| applyAnimationClasses(element, options); | |||
| applyAnimationStyles(element, options); | |||
|
|
|||
| // we need to clear the cache since the post-quiet state may add and remove CSS | |||
| // classes which contain follow-up animation data which will be cached. | |||
| $$rAF(function() { | |||
There was a problem hiding this comment.
It doesn't make any difference, but it could be $$rAF(flushGCSCache).
…ion is closed In the post-quiet animation detection phase of $animateCss there is a call to getComputedStyle which is cached, however, the cache is not cleared until the next animation is run. This causes a caching issue since the next animation's cache data may be read and provided incorrectly. This patch clears the cache after each animation has closed itself. Closes angular#11723
matsko
changed the title
matsko
changed the title
|
Closed in favour of: #11852 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11723