Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngAnimate disrupts correct validation of input type email #12007

Closed
JPtenBerge opened this issue Jun 2, 2015 · 5 comments
Closed

ngAnimate disrupts correct validation of input type email #12007

JPtenBerge opened this issue Jun 2, 2015 · 5 comments
Assignees
@matsko
Labels
component: ngAnimate severity: broken expected use severity: regression type: bug
Milestone
1.4.4

Comments

@JPtenBerge
Copy link

Hi there,

With the newest version (1.4.0) it seems that email validation does not fully work correctly when the ngAnimate module gets included. Check out this Plnkr: http://plnkr.co/edit/mRvFhnpgZCKTI1YPWqkT?p=preview.

Try entering a value like '@@@', '|||' or 'qqq'. The model value only gets updated when a true valid value is entered, but the ng-valid/ng-invalid classes get applied wrongly. Removing the ngAnimate module as a dependency and the ng-valid/invalid classes work just fine.

I'm experiencing this on Windows 7 and 8, in IE as well as Chrome and Firefox.

JP
@Narretz Narretz added this to the 1.4.1 milestone Jun 3, 2015
@Narretz
Copy link
Contributor

Narretz commented Jun 3, 2015

@matsko Wasn't there a similar bug that was already fixed? Or is this the same problem?

@Narretz
Copy link
Contributor

Narretz commented Jun 3, 2015

This seems to be the same issue: #11652

@gkalpak
Copy link
Member

gkalpak commented Jun 3, 2015

It is quite similar, but I don't think it is the same issue, because #11652 has been fixed (demo), but this one is still reproducible on master.

Also, the wrong behaviour is different: This one seems to incorrectly apply the valid classes every 3 keystrokes, even if the value is invalid. Weird and interesting :)

@petebacondarwin petebacondarwin modified the milestones: 1.4.1, 1.4.2 Jun 16, 2015
@gkalpak gkalpak mentioned this issue Jun 18, 2015
Closed
@petebacondarwin petebacondarwin modified the milestones: 1.4.2, 1.4.3 Jul 6, 2015
@Narretz Narretz mentioned this issue Jul 10, 2015
Closed
@sreeramu sreeramu mentioned this issue Jul 10, 2015
Closed
@matsko matsko modified the milestones: 1.4.3, 1.4.4 Jul 14, 2015
@matsko matsko closed this as completed in 21d6db3 Jul 17, 2015
@matsko
Copy link
Contributor

matsko commented Jul 17, 2015

This is now fixed in master courtesy of @sreeramu.

@matsko
Copy link
Contributor

matsko commented Jul 17, 2015

1.4.4 will land next week as well.

netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@sreeramu @netman92
fix($animate): ensure that class-based animations are properly applie…
b50029f 
…d when cancelled

Instead of merging existing animation option to new animation options we can
merge in reverse and utilize old animation runner.

Closes angular#12266
Closes angular#12007
@petebacondarwin petebacondarwin mentioned this issue Sep 24, 2015
Closed
ggershoni pushed a commit to ggershoni/angular.js that referenced this issue Sep 29, 2015
@sreeramu @matsko
fix($animate): ensure that class-based animations are properly applie…
cf9a681 
…d when cancelled

Instead of merging existing animation option to new animation options we can
merge in reverse and utilize old animation runner.

Closes angular#12266
Closes angular#12007
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
component: ngAnimate severity: broken expected use severity: regression type: bug
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
5 participants
@petebacondarwin @matsko @Narretz @JPtenBerge @gkalpak