Having custom Object.prototype method prevents form validation #12066

funkflute · 2015-06-09T22:45:17Z

I'm running into this issue that if I set a custom Object.prototype method, it stops form validation from updating:

<!DOCTYPE html>
<html lang="en">
    <head>
        <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
        <title>Test</title> 
    </head>
    <body ng-app>
        <form name="testForm" novalidate>
            <!-- type in here and field and form should turn valid -->
            <input type="text" name="test" ng-model="test" required> Field Valid? {{testForm.test.$valid | json}}
        </form>
        Form valid? {{testForm.$valid | json}}

        <script src="http://ajax.googleapis.com/ajax/libs/angularjs/1.4.0/angular.min.js"></script>
        <script>
            // remove this line and validation works again
            Object.prototype.someThing = function() {}
        </script>
    </body>
</html>

The text was updated successfully, but these errors were encountered:

ryanhart2 · 2015-06-10T03:59:02Z

Here is a plunk http://plnkr.co/edit/XauBqEKawyDyk21RFc1r?p=preview demonstrating the behaviour (the prototype method is set in script.js). The issue seems to have started in version 1.3.0-rc.1 so that is what I have used in the plunk.

…rable value When adding an Object.prototype enumerable property, this should not be confused as a form error Closes angular#12066

lgalfaso · 2015-06-10T10:47:45Z

The check that there are no errors in the errors object was not checking that any of the properties comes from the Object.prototype. #12075 should take care of this

…rable value When adding an Object.prototype enumerable property, this should not be confused as a form error Closes angular#12066

lgalfaso mentioned this issue Jun 10, 2015

fix(ngModel): form validation and Object.prototype enumerable values #12075

Closed

Narretz added type: bug component: forms severity: broken expected use labels Jun 10, 2015

Narretz modified the milestones: 1.4.1, 1.4.x Jun 10, 2015

lgalfaso closed this as completed in 0934b76 Jun 11, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Having custom Object.prototype method prevents form validation #12066

Having custom Object.prototype method prevents form validation #12066

funkflute commented Jun 9, 2015

ryanhart2 commented Jun 10, 2015

lgalfaso commented Jun 10, 2015

Having custom Object.prototype method prevents form validation #12066

Having custom Object.prototype method prevents form validation #12066

Comments

funkflute commented Jun 9, 2015

ryanhart2 commented Jun 10, 2015

lgalfaso commented Jun 10, 2015