Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Linky does not work with case-insensitive schemes #12073

Closed
BiohZn opened this issue Jun 10, 2015 · 4 comments
Closed

Linky does not work with case-insensitive schemes #12073

BiohZn opened this issue Jun 10, 2015 · 4 comments

Comments

@BiohZn
Copy link
Contributor

BiohZn commented Jun 10, 2015

According to RFC 3986 (http://tools.ietf.org/html/rfc3986#section-3.1) scheme such as http or mailto are case-insensitive. So links such as http://server/ and HTTP://server/ are valid and equivalent.

However, the linky filter recognizes only links with lowercase schemes as links. While http://server/ will be recognized as a link, HTTP://server will be not.

NOTE: This is a duplicate of #3210

@petebacondarwin
Copy link
Contributor

@BiohZn - would you like to make a PR from your commit with an appropriate unit test?

@BiohZn
Copy link
Contributor Author

BiohZn commented Jun 10, 2015

@petebacondarwin I'm not 100% comfortable with making unit tests, but I can add some, yes.

@petebacondarwin
Copy link
Contributor

Magic. It is fun to get outside your comfort zone. I will help you as you need it. Take the tests in 7fef06f and https://github.com/angular/angular.js/blob/master/test/ngSanitize/filter/linkySpec.js#L27-L36 as starting points.

@BiohZn
Copy link
Contributor Author

BiohZn commented Jun 10, 2015

@petebacondarwin one misconfigured git commit later, it should now be ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants