ngAnimate - Providing only keyframe/keyframeStyles to $animateCss does nothing #12124

intellix · 2015-06-15T14:50:38Z

After realising that keyframe should actually be keyframeStyles for $animateCss I see that passing keyframeStyles alone will decide that there's nothing to do and return: closeAndReturnNoopAnimator().

To get around this I have to do something like:

$animateCss(ele, { 
  keyframeStyles: '1s my-anim ease',
  addClass: 'meh'
});

The text was updated successfully, but these errors were encountered:

Narretz · 2015-06-20T22:06:08Z

The comment before the return in question says:

      // there is no way we can trigger an animation since no styles and
      // no classes are being applied which would then trigger a transition

(https://github.com/angular/angular.js/blob/master/src/ngAnimate/animateCss.js#L560)

If that is correct, the documention needs to be updated. @matsko do you know if that is the case?

…s provided `$animateCss` is a fan of transition animations, but it turns out that if only a keyframeStyle is provided into the animation upon constrution then it will quit because it assumes that nothing will be animated (since no classes or styles are being applied). This patch ensures that a keyframe style can solely be applied to an animation triggered with `$animateCss`. ```js // this will now work as expected $animateCss(element, { keyframeStyle: '1s rotate' }).start(); ``` Closes angular#12124

matsko · 2015-07-14T00:40:09Z

Excellent find. This PR will fix this issue and we should have it ready for tomorrow's release (1.4.3):

#12340

…s provided `$animateCss` is a fan of transition animations, but it turns out that if only a keyframeStyle is provided into the animation upon constrution then it will quit because it assumes that nothing will be animated (since no classes or styles are being applied). This patch ensures that a keyframe style can solely be applied to an animation triggered with `$animateCss`. ```js // this will now work as expected $animateCss(element, { keyframeStyle: '1s rotate' }).start(); ``` Closes angular#12124 Closes angular#12340

Narretz added type: bug component: ngAnimate labels Jun 16, 2015

Narretz added this to the 1.4.2 milestone Jun 16, 2015

Narretz added the severity: broken expected use label Jun 16, 2015

Narretz self-assigned this Jun 19, 2015

Narretz assigned matsko and unassigned Narretz Jun 20, 2015

petebacondarwin modified the milestones: 1.4.2, 1.4.3 Jul 6, 2015

matsko mentioned this issue Jul 14, 2015

fix($animateCss): ensure animations execute if only a keyframeStyle is provided #12340

Closed

matsko closed this as completed in 97d79ee Jul 14, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ngAnimate - Providing only keyframe/keyframeStyles to $animateCss does nothing #12124

ngAnimate - Providing only keyframe/keyframeStyles to $animateCss does nothing #12124

intellix commented Jun 15, 2015

Narretz commented Jun 20, 2015

matsko commented Jul 14, 2015

ngAnimate - Providing only keyframe/keyframeStyles to $animateCss does nothing #12124

ngAnimate - Providing only keyframe/keyframeStyles to $animateCss does nothing #12124

Comments

intellix commented Jun 15, 2015

Narretz commented Jun 20, 2015

matsko commented Jul 14, 2015