Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngAnimate messing with validation classes #12266

Closed
crisbeto opened this issue Jul 3, 2015 · 4 comments
Closed

ngAnimate messing with validation classes #12266

crisbeto opened this issue Jul 3, 2015 · 4 comments

Comments

@crisbeto
Copy link
Member

crisbeto commented Jul 3, 2015

Since 1.4.0, ngAnimate has been messing with the way ng-valid/ng-invalid classes are being applied. Here's a plunker with an example (forked from the official email example): http://plnkr.co/edit/THMRi4lrFoVUMOFsmeli?p=preview

To reproduce, try entering any random value whose length is divisble by 3 (e.g. "123"). Note that the input and the form have the ng-valid class, in addition to ng-invalid-email, even though the value isn't a valid email. The correct behavior is for them to both be ng-invalid.

The problem gets solved if ngAnimate gets commented out from the dependencies.
@gkalpak
Copy link
Member

gkalpak commented Jul 3, 2015

I am pretty sure there is a duplicate issue, but I can't find it 😞

@sreeramu sreeramu mentioned this issue Jul 6, 2015
Closed
@Narretz
Copy link
Contributor

Narretz commented Jul 10, 2015

Looks like a dupe of #12007

@Narretz Narretz closed this as completed Jul 10, 2015
@gkalpak
Copy link
Member

gkalpak commented Jul 10, 2015

Yup, that's the one !
👍 @Narretz 😃

matsko pushed a commit that referenced this issue Jul 17, 2015
@sreeramu @matsko
fix($animate): ensure that class-based animations are properly applie…
21d6db3 
…d when cancelled

Instead of merging existing animation option to new animation options we can
merge in reverse and utilize old animation runner.

Closes #12266
Closes #12007
@crisbeto
Copy link
Member Author

Can confirm that it works fine with a snapshot of 1.4.4. Thank you!
Here's a forked plunk: http://plnkr.co/edit/5xECEaHLGizWsJ82WUTj?p=preview

netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@sreeramu @netman92
fix($animate): ensure that class-based animations are properly applie…
b50029f 
…d when cancelled

Instead of merging existing animation option to new animation options we can
merge in reverse and utilize old animation runner.

Closes angular#12266
Closes angular#12007
ggershoni pushed a commit to ggershoni/angular.js that referenced this issue Sep 29, 2015
@sreeramu @matsko
fix($animate): ensure that class-based animations are properly applie…
cf9a681 
…d when cancelled

Instead of merging existing animation option to new animation options we can
merge in reverse and utilize old animation runner.

Closes angular#12266
Closes angular#12007
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #12266 : Fixed skipping/cleaning of elements pending animations.
3 participants
@Narretz @crisbeto @gkalpak