Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

$$rAF performance issue in Angular Material #12280

Closed
ThomasBurleson opened this issue Jul 6, 2015 · 12 comments
Closed

$$rAF performance issue in Angular Material #12280

ThomasBurleson opened this issue Jul 6, 2015 · 12 comments
Assignees
@matsko
Labels
component: ngAnimate type: perf
Milestone
1.4.5

Comments

@ThomasBurleson
Copy link

When scrolling sticky md-subheader, recent changes in $$rAF seem to create excessive CPU usages.
See angular/material#3531 for details and CodePen demos.
@ThomasBurleson ThomasBurleson mentioned this issue Jul 6, 2015
Closed
@Narretz Narretz added this to the 1.4.2 milestone Jul 6, 2015
@ThomasBurleson
Copy link
Author

Thx @Narretz

@petebacondarwin petebacondarwin modified the milestones: 1.4.2, 1.4.3 Jul 6, 2015
@ThomasBurleson
Copy link
Author

More issues:

@AdriVanHoudt
Copy link

Any movement on this? We have to resort to using 1.3.15...

@itsmichaeldiego
Copy link

Same as @AdriVanHoudt , any movement?

matsko added a commit to matsko/angular.js that referenced this issue Jul 14, 2015
@matsko
fix(ngAnimate): buffer repeated calls to RAF to improve performance f…
1cc6317 
…or animations

Prior to this patch ngAnimate buffered all repeated calls to
requestAnimationFrame into a task queue that is flushed once the next
animation frame has passed. While this works it causes a random lag to
jump out when any CPU intensive rAF requests are processed. This patch
sets a configurable task range which then offsets followup rAF requests
into the next available frame.

Closes angular#12280
@matsko matsko mentioned this issue Jul 14, 2015
Closed
matsko added a commit to matsko/angular.js that referenced this issue Jul 14, 2015
@matsko
fix(ngAnimate): buffer repeated calls to RAF to improve performance f…
6dcca5a 
…or animations

Prior to this patch ngAnimate buffered all repeated calls to
requestAnimationFrame into a task queue that is flushed once the next
animation frame has passed. While this works it causes a random lag to
jump out when any CPU intensive rAF requests are processed. This patch
sets a configurable task range which then offsets followup rAF requests
into the next available frame.

Closes angular#12280
matsko added a commit to matsko/angular.js that referenced this issue Jul 14, 2015
@matsko
fix(ngAnimate): buffer repeated calls to RAF to improve performance f…
56fe8db 
…or animations

Prior to this patch ngAnimate buffered all repeated calls to
requestAnimationFrame into a task queue that is flushed once the next
animation frame has passed. While this works it causes a random lag to
jump out when any CPU intensive rAF requests are processed. This patch
sets a configurable task range which then offsets followup rAF requests
into the next available frame.

Closes angular#12280
@matsko matsko modified the milestones: 1.4.3, 1.4.4 Jul 14, 2015
@Mctalian Mctalian mentioned this issue Jul 15, 2015
Closed
@Narretz Narretz modified the milestones: 1.4.4, 1.4.5 Aug 14, 2015
@AdriVanHoudt
Copy link

The commit is there why wasn't this included in 1.4.4?

@matsko
Copy link
Contributor

matsko commented Aug 17, 2015

@AdriVanHoudt the commit wasn't guaranteed to fix it. We're testing to see if we can use setTimeout in IE to make this work better.

@AdriVanHoudt
Copy link

@matsko cool, let me know if I can help and of you know an ETA that would be helpfull

@matsko
Copy link
Contributor

matsko commented Aug 17, 2015

It's set as the main fix for 1.4 this week. So it should be done for the next release.

@AdriVanHoudt
Copy link

Cool, thanks for all the work!

@itsmichaeldiego
Copy link

Thanks guys!

@matsko matsko mentioned this issue Aug 19, 2015
Closed
matsko added a commit to matsko/angular.js that referenced this issue Aug 19, 2015
@matsko
fix(ngAnimate): only buffer rAF requests within the animation runners
6482871 
Closes angular#12280
matsko added a commit to matsko/angular.js that referenced this issue Aug 19, 2015
@matsko
fix(ngAnimate): only buffer rAF requests within the animation runners
fbc0823 
Closes angular#12280
@matsko matsko closed this as completed Aug 19, 2015
@matsko
Copy link
Contributor

matsko commented Aug 19, 2015

1.4.5 will have the fix.

matsko added a commit that referenced this issue Aug 19, 2015
@matsko
fix(ngAnimate): only buffer rAF requests within the animation runners
dc48aad 
Closes #12280
@AdriVanHoudt
Copy link

🎉 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
component: ngAnimate type: perf
Projects
None yet
Milestone
1.4.5
Development

Successfully merging a pull request may close this issue.

fix(ngAnimate): only buffer rAF requests within the animation runners matsko/angular.js
6 participants
@petebacondarwin @matsko @ThomasBurleson @Narretz @AdriVanHoudt @itsmichaeldiego