This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($animateCss): ensure animations execute if only a keyframeStyle is provided #12340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s provided
`$animateCss` is a fan of transition animations, but it turns out that
if only a keyframeStyle is provided into the animation upon constrution
then it will quit because it assumes that nothing will be animated
(since no classes or styles are being applied). This patch ensures that
a keyframe style can solely be applied to an animation triggered with
`$animateCss`.
```js
// this will now work as expected
$animateCss(element, { keyframeStyle: '1s rotate' }).start();
```
Closes angular#12124
Closes angular#12340
matsko
force-pushed
the
fix_keyframe_styles_bug
branch
from
b54eefd to
a0569b2
Compare
…igger anything Using `transitionStyle` without any other properties does not trigger an animation so we could have a test to assert that it doesn't do that.
matsko
force-pushed
the
fix_keyframe_styles_bug
branch
from
a0569b2 to
3262d45
Compare
|
|
||
| // there is no way we can trigger an animation since no styles and | ||
| // no classes are being applied which would then trigger a transition | ||
| if (!hasToStyles && !setupClasses) { | ||
| // is there a raw keyframe value that is applied to the element |
There was a problem hiding this comment.
This comment seems a bit weird in the context of the previous two lines...
Perhaps these three comment lines should read:
// there is no way we can trigger an animation if no styles and
// no classes are being applied which would then trigger a transition,
// unless there a is raw keyframe value that is applied to the element
netman92
pushed a commit
to netman92/angular.js
that referenced
this pull request
Aug 8, 2015
…s provided
`$animateCss` is a fan of transition animations, but it turns out that
if only a keyframeStyle is provided into the animation upon constrution
then it will quit because it assumes that nothing will be animated
(since no classes or styles are being applied). This patch ensures that
a keyframe style can solely be applied to an animation triggered with
`$animateCss`.
```js
// this will now work as expected
$animateCss(element, { keyframeStyle: '1s rotate' }).start();
```
Closes angular#12124
Closes angular#12340
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$animateCssis a fan of transition animations, but it turns out thatif only a keyframeStyle is provided into the animation upon constrution
then it will quit because it assumes that nothing will be animated
(since no classes or styles are being applied). This patch ensures that
a keyframe style can solely be applied to an animation triggered with
$animateCss.Closes #12124