Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

ngAnimate's new reflow system forgets to run a reflow for parentless animations #12400

Closed
matsko opened this issue Jul 22, 2015 · 1 comment
Closed

ngAnimate's new reflow system forgets to run a reflow for parentless animations #12400

matsko opened this issue Jul 22, 2015 · 1 comment
Assignees
@matsko
Labels
component: ngAnimate severity: regression
Milestone
1.4.4

Comments

@matsko
Copy link
Contributor

matsko commented Jul 22, 2015

Turns out that if we don't have a parent, class-based animation waiting on some elements then a reflow isn't run directly after postDigest.

http://plnkr.co/edit/19zd2RYTRaCxAymbwxkv?p=preview

This PR fixes it: #12401
matsko added a commit to matsko/angular.js that referenced this issue Jul 22, 2015
@matsko
fix($animate): make sure to run a post-digest reflow for parentless a…
f83693e 
…nimations

Closes angular#12400
@matsko matsko mentioned this issue Jul 22, 2015
Closed
@matsko matsko self-assigned this Jul 22, 2015
@matsko matsko added this to the 1.4.4 milestone Jul 22, 2015
matsko added a commit to matsko/angular.js that referenced this issue Jul 22, 2015
@matsko
fix($animate): make sure to run a post-digest reflow for parentless a…
136c317 
…nimations

Closes angular#12400
Closes angular#12401
matsko added a commit to matsko/angular.js that referenced this issue Jul 22, 2015
@matsko
fix($animate): make sure to run a post-digest reflow for parentless a…
393226a 
…nimations

Closes angular#12400
Closes angular#12401
@petebacondarwin
Copy link
Contributor

@matsko - sorry, I can't see what the issue is in that Plunker. What is supposed to happen?

@matsko matsko closed this as completed in 861636c Jul 27, 2015
netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@matsko @netman92
fix($animate): make sure to run a post-digest reflow for parentless a…
1e494b8 
…nimations

Closes angular#12400
Closes angular#12401
ggershoni pushed a commit to ggershoni/angular.js that referenced this issue Sep 29, 2015
@matsko
fix($animate): make sure to run a post-digest reflow for parentless a…
33af1d7 
…nimations

Closes angular#12400
Closes angular#12401
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
component: ngAnimate severity: regression
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
2 participants
@petebacondarwin @matsko