-
Notifications
You must be signed in to change notification settings - Fork 27.4k
ngHide/ng-show directive don't animate in ng 1.4.4 #12631
Comments
Can you please provide a demo of the problem? Otherwise, we cannot do anything to fix the problem. |
Just look how work original example or plunker
|
Ok, I see now. @matsko can you take a look at this? It seems pretty bad if even the "official" ng-hide animations aren't working. |
The animation example contains unnecessarily complex CSS animation code in it and the conventions are off. Related angular#12631
The animation example contains unnecessarily complex CSS animation code in it and the conventions are off. Related angular#12631
Turns out that the API docs example code is incorrect. Transitions always need to be applied to the non active CSS class: Or on the class that is being added or removed: Or on a shared CSS class that is always there: Placing it on the active CSS classes may have worked before, however it was never intended. But not to worry, I will look into making the fix properly for 1.4.5. Here is an issue to keep note of that: In the meantime here is a commit that will clean up the example in the docs a bit so nobody else comes across this issue: |
…e active classes This allows for CSS transitions to be defined on the active CSS class if desired. Closes angular#12631
The animation example contains unnecessarily complex CSS animation code in it and the conventions are off. Related #12631
Sorry I provided the wrong link earlier. Here is a patched version of angular.js that fixes the issue: http://plnkr.co/edit/YLTe1SObEAaQn99iOiNv?p=preview This patch will debut in 1.4.5 |
This reverts the previous behaviour of using foreced reflows to deal with preparation classes in favour of a system that uses requestAnimationFrame (RAF). Closes angular#12669 Closes angular#12594 Closes angular#12655 Closes angular#12631 Closes angular#12612
This reverts the previous behaviour of using foreced reflows to deal with preparation classes in favour of a system that uses requestAnimationFrame (RAF). Closes angular#12669 Closes angular#12594 Closes angular#12655 Closes angular#12631 Closes angular#12612 Closes angular#12187
@matsko thx! =) |
This reverts the previous behaviour of using foreced reflows to deal with preparation classes in favour of a system that uses requestAnimationFrame (RAF). Closes angular#12669 Closes angular#12594 Closes angular#12655 Closes angular#12631 Closes angular#12612 Closes angular#12187
This reverts the previous behaviour of using foreced reflows to deal with preparation classes in favour of a system that uses requestAnimationFrame (RAF). Closes angular#12669 Closes angular#12594 Closes angular#12655 Closes angular#12631 Closes angular#12612 Closes angular#12187
when i update to angular 1.4.4, there is a strange thing -- some animation i define for the element with ng-hide directive doesn't seem to work. Then i check the api docs. Ok, the 1.4.4 version docs of ng-show's example plunkr seems to have no animation too.
Does Angular have enough tests before the new version is about to release?
The text was updated successfully, but these errors were encountered: