Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

View transition animations break with single ng-animate-ref 1.4.4 and snapshot #12655

Closed
roblouie opened this issue Aug 22, 2015 · 2 comments
Closed

View transition animations break with single ng-animate-ref 1.4.4 and snapshot #12655

roblouie opened this issue Aug 22, 2015 · 2 comments

Comments

@roblouie
Copy link

When using a view transition animation and ng-animate-ref, if you have only a single ng-animate-ref it breaks the view transition animation.

Take this lightly modified version of the ng-animate-ref example from the Angular documentation. I have modified it to just show a link to a single record rather than a list. Notice the page sliding is no longer working properly:
http://plnkr.co/edit/n5WPBEyF04WxAEb2bnFi?p=preview

By adding an empty span with a nonsense ng-animate-ref, the issue goes away:
http://plnkr.co/edit/ua4e00iUajeh0dcu7UF9?p=preview

The issue also resolves by simply reverting to 1.4.3:
http://plnkr.co/edit/Lq9AoWo6Hz3qpCbNie92?p=preview

Updating to snapshot version does not resolve the issue.
@roblouie roblouie changed the title View transition animations break with single ng-animation-ref 1.4.4 and snapshot View transition animations break with single ng-animate-ref 1.4.4 and snapshot Aug 22, 2015
@matsko
Copy link
Contributor

matsko commented Aug 25, 2015

Here's a demo with a patch that will go into 1.4.5: http://plnkr.co/edit/1gTNNLBEPwiDlJYXxudu?p=preview

@matsko
Copy link
Contributor

matsko commented Aug 25, 2015

I'm super happy to see you're using the anchoring feature :)

matsko added a commit to matsko/angular.js that referenced this issue Aug 25, 2015
@matsko
fix(ngAnimate): use requestAnimationFrame to space out child animations
9d4d9be 
This reverts the previous behaviour of using foreced reflows to deal
with preparation classes in favour of a system that uses
requestAnimationFrame (RAF).

Closes angular#12669
Closes angular#12594
Closes angular#12655
Closes angular#12631
Closes angular#12612
@matsko matsko mentioned this issue Aug 25, 2015
Closed
matsko added a commit to matsko/angular.js that referenced this issue Aug 25, 2015
@matsko
fix(ngAnimate): use requestAnimationFrame to space out child animations
3945e47 
This reverts the previous behaviour of using foreced reflows to deal
with preparation classes in favour of a system that uses
requestAnimationFrame (RAF).

Closes angular#12669
Closes angular#12594
Closes angular#12655
Closes angular#12631
Closes angular#12612
Closes angular#12187
matsko added a commit to matsko/angular.js that referenced this issue Aug 27, 2015
@matsko
fix(ngAnimate): use requestAnimationFrame to space out child animations
c281841 
This reverts the previous behaviour of using foreced reflows to deal
with preparation classes in favour of a system that uses
requestAnimationFrame (RAF).

Closes angular#12669
Closes angular#12594
Closes angular#12655
Closes angular#12631
Closes angular#12612
Closes angular#12187
matsko added a commit to matsko/angular.js that referenced this issue Aug 27, 2015
@matsko
fix(ngAnimate): use requestAnimationFrame to space out child animations
7b5e22d 
This reverts the previous behaviour of using foreced reflows to deal
with preparation classes in favour of a system that uses
requestAnimationFrame (RAF).

Closes angular#12669
Closes angular#12594
Closes angular#12655
Closes angular#12631
Closes angular#12612
Closes angular#12187
@matsko matsko closed this as completed in ea8016c Aug 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matsko @roblouie