Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Please create a component package #1322

Closed
jasonkuhrt opened this issue Aug 30, 2012 · 18 comments
Closed

Please create a component package #1322

jasonkuhrt opened this issue Aug 30, 2012 · 18 comments

Comments

@jasonkuhrt
Copy link

Although the size of angularjs is somewhat contrary to the goals of component it would still be beneficial for projects to be able to consume angularjs as a component for those really requiring such a framework.

https://github.com/component/component/

@mhevery
Copy link
Contributor

mhevery commented Aug 31, 2012

would you like to create a pull request?

On Thu, Aug 30, 2012 at 12:41 PM, Jason Kuhrt notifications@github.comwrote:

This would be very much appreciated.

I wonder/realize you guys might be waiting for/relying on yeoman.io for
package distribution but until then something we can use through (for
example) browserify would be, again, much appreciated.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1322.

@johnsextro
Copy link

mhevery,

I'd like to take on this chore. I'll put in a pull request when its ready. Please let me know if you have any additional information to provide for the task.

@jasonkuhrt
Copy link
Author

Sorry I never followed up on this issue. I'm updating this issue to reflect the preferred package manager solution which would be component(1): https://github.com/component/component/

I do not think npm would be the correct approach at all now.

@johnsextro
Copy link

jasonkuhrt,

Ok. Then I'll package it as a "component". Is this ok with everyone?

@pkozlowski-opensource
Copy link
Member

@jasonkuhrt @johnsextro Could I hold you back a bit guys?

There is a big PR waiting to be merged switching the build system from the current rake to Grunt:
#1544

The package (whatever the package manager) should be generated during the build time so till the build is sorted out I don't think it makes much sense to work on this topic.

@johnsextro There are plenty of other issues marked with the docs or community label if you want to take a stab at something...

@johnsextro
Copy link

Yeah. Sure thing. I'll look around and find another something to work on.

@casio
Copy link

casio commented Jan 25, 2013

+1

It'd be super awesome to have a component/component version of angular(and it's add-on modules).

I did a really dirty test here: https://github.com/casio/angular.js/tree/1.1.0
This allows you to start an angular project or component by just adding "casio/angular.js": "1.1.0" to your dependencies, which is pretty cool. It'd get really cool, if adding eg $resource is just as easy.

This would be totally great for projects like angular-ui, angular-strap but also for standalone components like directives, etc.

Now, while work on this might wait until the grunt switch is done, we could already evaluate how to approach this.
If I get it right, then for each add-on module(and locale?) there had to be a separate github repo, which might be unwanted. Maybe we could ask @visionmedia for hints?!

@tj
Copy link

tj commented Jan 26, 2013

Like @jasonkuhrt mentioned it would be beneficial even when only used as a build system, angular could still be distributed in the same way, but allowing other people to use each subset as standalone libs/components would be nice too. I'm not sure how coupled the internals are, but even if they're coupled it's still a build tool for large projects. As far as all of angular being a component, I dont think it would end up too nice really, you could do it I suppose but it would be like packing 20 libraries into one

@nl0
Copy link

nl0 commented May 13, 2013

how's it going, guys?

@jasonkuhrt
Copy link
Author

Based on recent angular presentations It appears that angular is going towards the bower/yeoman for package management and optional AMD for module management.

If the Angular teams is certain that component is not going to receive support what-so-ever please close this issue.

@leostera
Copy link
Contributor

If anybody is interested in this, I'm using the latest angular version and maintain an updated fork here: https://github.com/leostera/angular.js

Every 1 hour an ec2 instance uses componentizr (https://github.com/leostera/componentizr) to make a component.io module.

I could do the same for the different angular pieces (routes, animate, sanitize, resource, etc) if someone requested so but I have no hurry in doing it for a couple weeks at least.

@jasonkuhrt
Copy link
Author

@leostera looks great, thanks.

@leostera
Copy link
Contributor

can you give me some more context?, did you do component install after
adding it to the dependencies?

On Thu, Oct 10, 2013 at 10:32 AM, Jason Kuhrt notifications@github.comwrote:

@leostera https://github.com/leostera I get this error when I try to
build with your repo includes as a dep:

"dependencies": {
"leostera/angular.js": "*",

ϟ component build

   error : failed to lookup "bitboard_app"'s dependency "leostera-angular.js"


Reply to this email directly or view it on GitHubhttps://github.com//issues/1322#issuecomment-26053532
.

Leandro Ostera
Web Engineer

I hack at github.com/leostera
I talk on skype as leostera
I tweet as @leostera http://twitter.com/leostera
I blog at blog.leostera.com
I network at angel.co/leostera
I video at vimeo.com/leostera
I play bass at soundcloud.com/leostera
I'm also on linkedin.com/in/leostera
And yeah, I need a new signature.

@jasonkuhrt
Copy link
Author

All good, it works if I component install but not if I edit the component json. Thanks.

Sent from my iPhone

On Oct 11, 2013, at 5:47, Leandro Ostera notifications@github.com wrote:

can you give me some more context?, did you do component install after
adding it to the dependencies?

On Thu, Oct 10, 2013 at 10:32 AM, Jason Kuhrt notifications@github.comwrote:

@leostera https://github.com/leostera I get this error when I try to
build with your repo includes as a dep:

"dependencies": {
"leostera/angular.js": "*",

ϟ component build

error : failed to lookup "bitboard_app"'s dependency "leostera-angular.js"


Reply to this email directly or view it on GitHubhttps://github.com//issues/1322#issuecomment-26053532
.

Leandro Ostera
Web Engineer

I hack at github.com/leostera
I talk on skype as leostera
I tweet as @leostera http://twitter.com/leostera
I blog at blog.leostera.com
I network at angel.co/leostera
I video at vimeo.com/leostera
I play bass at soundcloud.com/leostera
I'm also on linkedin.com/in/leostera
And yeah, I need a new signature.

Reply to this email directly or view it on GitHub.

@leostera
Copy link
Contributor

You have to do a component install even if you modify the component.json
manually. Think of it like npm i and manually adding a dependency in the
package.json.

@leostera
Copy link
Contributor

Just finished splitting angular up into it's submodules. Now you can go

$ component install componentizr/angular.js
// and from your code
require('angular.js')

or any of it's submodules

$ component install componentizr/angular-route
// and from your code
require('angular-route')

Now you can build your component app and not bundle a bunch of stuff that
you don't need from angular (mock, scenario?)

All this repos are automatically updated and are available at https://github.com/componentizr

@casio
Copy link

casio commented Oct 20, 2013

@leostera very cool, thanks for your efforts!

@btford
Copy link
Contributor

btford commented Dec 19, 2013

Very cool! Thanks @leostera!

@btford btford closed this as completed Dec 19, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants