Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Do not use event.timeStamp anymore #13494

Closed
matsko opened this issue Dec 10, 2015 · 1 comment
Closed

Do not use event.timeStamp anymore #13494

matsko opened this issue Dec 10, 2015 · 1 comment

Comments

@matsko
Copy link
Contributor

matsko commented Dec 10, 2015

With the forthcoming releases for Firefox 44 and new versions of Chromium and Webkit, the use of event.timeStamp will yield a different value compared to what it did before. Therefore for this reason, all versions of ngAnimate will make use of Date.now() to leverage timing values within animations.

Original bug report:
https://bugzilla.mozilla.org/show_bug.cgi?id=1231619#c3

Changes to Chromium:
https://code.google.com/p/chromium/issues/detail?id=160524

@angular angular locked and limited conversation to collaborators Dec 10, 2015
@petebacondarwin petebacondarwin added this to the 1.5.0-rc.1 milestone Dec 10, 2015
@matsko
Copy link
Contributor Author

matsko commented Jan 6, 2016

Landed as e020b89

@matsko matsko closed this as completed Jan 6, 2016
cadams500 pushed a commit to SparkPost/angular.js that referenced this issue Oct 5, 2023
Due to recent changes in Chrome, Firefox and Webkit use of the
event.timeStamp value will lead to unpredictable behaviour due to
precision changes. Therefore it's best to stick entirely to use
`Date.now()` when it comes to confirming the end of transition-
ending values. See angular#13494 for more info.

Applies to 1.2, 1.3, 1.4 and 1.5.

Closes angular#13494
Closes angular#13495
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants