Impossible to inject providers into Module.provider() when array-style DI-annotations are used

[pkozlowski-opensource]

Problem description

It is impossible to define a provider that depends on another provider in the minified version of an application. The following code:

var myApp = angular.module('myApp', []).provider('crudRouteProvider', ['$routeProvider', function(e) {

    this.doSthWithRouteProvider= function(pathPrefix) {
        //do something with $routeProvider here
    };

    this.$get = function() {
        return {};
    };
}]);

will fail with Uncaught Error: Provider crudRouteProvider must define $get factory method. from myApp. Here is the jsFiddle: http://jsfiddle.net/pkozlowski_opensource/FGkdD/1/

Expected behavior

The unminified version works correctly, here is the jsFiddle: http://jsfiddle.net/pkozlowski_opensource/cHHJJ/
The minified version should behave exactly the same.

[mhevery]

if you set the compilation level to advanced then you have to tell compiler not to rename $get. this['$get'] should do the trick.

This is an issue with configuring the compiler not with angular.

[pkozlowski-opensource]

@mhevery Hmm, I'm probably missing sth but actually this fiddle: http://jsfiddle.net/pkozlowski_opensource/FGkdD/1/ exposes the problem when $get is not renamed (just simulating minifier behavior here).

In fact here is another fiddle without any minifications / variables renamed, just using array-style to specify injectables: http://jsfiddle.net/FGkdD/4/

So if I'm not mistaken the problem is really linked to the usage of the array-style of specifying dependencies... But once again, I might be misinterpreting things....

[mhevery]

I am sorry, but you are not explaining what exactly does not work. Why do
you think the compiler is breaking this?

On Sun, Oct 14, 2012 at 2:26 PM, Pawel Kozlowski
notifications@github.comwrote:

@mhevery https://github.com/mhevery Hmm, I'm probably missing sth but
actually this fiddle: http://jsfiddle.net/pkozlowski_opensource/FGkdD/1/exposes the problem when $get is
not renamed (just simulating minifier behavior here).

In fact here is another fiddle without any minifications / variables
renamed, just using array-style to specify injectables:
http://jsfiddle.net/FGkdD/4/

So if I'm not mistaken the problem is really linked to the usage of the
array-style of specifying dependencies... But once again, I might be
misinterpreting things....

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1452#issuecomment-9427968.

[petebacondarwin]

@mhevery
What I believe Pawel is saying is that we are not allowed to use the array form of dependency injection for providers:

angular.module('myApp', []).provider('crudRouteProvider', ['$routeProvider', function(e) { ...

This is not a supported syntax. The only parameters that module.provider accepts is ({string}, {function}), where the function must also have a $get method.

The module.provider function ought to accept a ({string}, {array | function}), where the array is a dependency style injection array.

Pete

[mhevery]

Ahh, this has nothing to do with compiler. The issue is that provider takes a constructor function or an object instance, but it fails to see if it is an array. This is a real issue.

[sudhirj]

Just submitted a fix - I'm guessing we just need to instantiate the array same way we would a normal function.

[jintoppy]

Getting error 'Uncaught Error: Unknown provider: crudRouteProvider from myApp '

http://jsfiddle.net/cHHJJ/2/

var myApp = angular.module('myApp', [])
  myApp.provider('crudRouteProvider', function($routeProvider) {

    this.defineCrudRoutes = function(pathPrefix) {
        //do something with $routeProvider here
        $routeProvider.when(pathPrefix+'/list', {});
        $routeProvider.when(pathPrefix+'/new', {});
        //etc.
    };

    this.$get = function() {
        return {};
    };
});

myApp.config(['crudRouteProvider', function(crudRouteProvider){
    crudRouteProvider.defineCrudRoutes('main');
}]);

Is this correct way?