Ng-switch commentary has unnecessary white space

[ivomju]

When creating ng-switch-when end commentary, because no comment is passed an unnecessary white space is generated.

Before:

<!-- end ngSwitchWhen: -->

Now:

<!-- end ngSwitchWhen:  -->

To prevent that we could do something like this:

compile.$$createComment = function(directiveName, comment) {
      var content = '';

      if (debugInfoEnabled) {
        content = ' ';
        content += (directiveName || '');
        content += ':';
        content += comment ? ' ' + comment : '';
        content += ' ';
      }

      return window.document.createComment(content);
    };

[arashkbanan]

ایول

[Narretz]

Thanks for the report. This looks pretty inconsequential, but we might incorporate this change if your open a PR with this.

[Narretz]

Anyway, does this cause you any problems in your app?

[ivomju]

Yep, this broke some unit tests because we've tested the html output. I will open a PR then, thanks.

[ivomju]

But as you said, this is inconsequential with no big impact.

[Narretz]

I'm curious, why would you test the output of ngSwitch in a unit test? Shouldn't you test for presence / absence of non-comment nodes? Because the comments added by angular directives are implementation details.

[ivomju]

Summing this up:

• Very old tests where we define our directive scope, compile it and checked the html output
• This is on our backlog team to refactor but, unfortunately, It's not a priority.

[ivomju]

Also, this HTML validation shouldn't be done in unit test IMO, automated tests exists for something.