This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
angular.merge fails with MediaStream objects #14941
Milestone
Comments
The angular.* helpers are mainly designed for the uses of Angular core, so we don't usually prioritize fixing bugs in them. Pull requests are welcome nevertheless. |
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Jun 6, 2017
This function has problems with special object types but since it's not used in core, it is not worth implementing fixes for these cases. A general purpose library like lodash (provides `merge`) should be used instead. Closes angular#12653 Closes angular#14941 Closes angular#15180 Closes angular#15992
2 tasks
Narretz
added a commit
to Narretz/angular.js
that referenced
this issue
Jun 6, 2017
This function has problems with special object types but since it's not used in core, it is not worth implementing fixes for these cases. A general purpose library like lodash (provides `merge`) should be used instead. Closes angular#12653 Closes angular#14941 Closes angular#15180 Closes angular#15992
The issue still exists with |
What is |
Il meant, |
Sorry you were not able to make yourself clear ... :D So for copy this should probably be fixed as copy is used by scope.$watch |
Actually, I can't see that extend is broken: https://plnkr.co/edit/B3LebuAQPoj6kRgS2eCG?p=preview I created an issue for copy: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
angular.merge
transforms MediaStream objects insrc
into plain JavaScript Objects.If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://plnkr.co or similar (template: http://plnkr.co/edit/tpl:yBpEi4).
With the template: https://plnkr.co/edit/4cBUxjdB4kya0s5Wtbxd?p=preview
Simpler: https://plnkr.co/edit/LGUAcCTbYyf4UTxSbvBC?p=preview
What is the expected behavior?
angular.merge
(and derived) should not alter MediaStream objects.What is the motivation / use case for changing the behavior?
Allow writing simpler/cleaner code. The workaround is simply to manually set the stream objects.
Which versions of Angular, and which browser / OS are affected by this issue? Did this work in previous versions of Angular? Please also test with the latest stable and snapshot (https://code.angularjs.org/snapshot/) versions.
Google Chrome - Version 51.0.2704.106 (64-bit)
Other browsers probably also affected.
Other information (e.g. stacktraces, related issues, suggestions how to fix)
MediaStream objects should be cloned properly (MDN:
MediaStream.clone()
) in the case ofangular.clone
, or copied as is inangular.merge
andangular.extend
.The text was updated successfully, but these errors were encountered: