Feature request - 'natural' treatment of null strings in default orderBy comparator

[arw-travela]

Feature request in response to #15293:

As of 1.3.7, orderBy on a collection of strings that includes null strings will sort those items with null strings as if they were the string 'null', so will place them in the middle of a sorted list. The "natural" sorting of null elements in a list is to put them at the end of the list (or front, when reverse-sorting). Note that this was the behavior pre-1.3.7.

[gkalpak]

To be clear this does not only affect lists of strings, but any values. Basically, null is treated in the exact same way as the string 'null' (as far orderBy is concerned).

It seems reasonable to treat it in a special way. Note that undefined is already put at the end of the list, because it's type 'undefined' happens to start with a u 😃 I think it makes sense to explicitly put null/undefined at the end of a sorted list.

Notes:

1. This will affect the default, built-in comparator for orderBy, as well as custom comparators.
2. The changes need to be clearly documented in the orderBy docs (which discusses the internal sorting algorithm).

[gitcoinbot]

This issue now has a funding of 0.02 ETH (6.02 USDT) attached to it. To view or claim this funding, click here.

[frederikprijck]

I'm working on this one, will create a PR asap.

[dntxos]

awesome @frederikprijck ... I liked this feature request and i was wanting to try gitcoin... ;-)

[owocki]

hey from gitcoin.co folks -- @frederikprijck did you ever turn this around? if not, let us know so we can source someone new. if so @dntxos maybe time to pay out?

[frederikprijck]

Hey @owocki / @dntxos ,

Sorry for taking so long, but the PR is up and awaiting reviewing. It looks like the gitcoin url is expired tho. I guess that makes me unable to claim it, right ? Any chance it can be refreshed ?

[owocki]

@dntxos you are the bounty submitter. are you still waying to pay out this bounty? cc @frederikprijck