This repository was archived by the owner on Apr 12, 2024. It is now read-only.
jqLite#removeData shouldn't touch the event handlers' storage #15869
Comments
mgol
added a commit
to mgol/angular.js
that referenced
this issue
Mar 26, 2018
This change aligns jqLite with jQuery. Fixes angular#15869 BREAKING CHANGE: Before this commit removeData() invoked on an element removed its event handlers as well. If you want to trigger a full cleanup of an element, change: elem.removeData(); to: angular.element.cleanData([elem]); In most cases, though, cleaning up after an element is supposed to be done only when it's removed from the DOM as well; in such cases the following: elem.remove(); will remove event handlers as well.
mgol
added a commit
to mgol/angular.js
that referenced
this issue
Mar 26, 2018
Fixes angular#15869 BREAKING CHANGE: Before this commit `removeData()` invoked on an element removed its event handlers as well. If you want to trigger a full cleanup of an element, change: ```js elem.removeData(); ``` to: ```js angular.element.cleanData([elem]); ``` In most cases, though, cleaning up after an element is supposed to be done only when it's removed from the DOM as well; in such cases the following: ```js elem.remove(); ``` will remove event handlers as well.
2 tasks
|
PR: #16512 |
mgol
added a commit
to mgol/angular.js
that referenced
this issue
Mar 26, 2018
This change aligns jqLite with jQuery. Fixes angular#15869 BREAKING CHANGE: Before this commit `removeData()` invoked on an element removed its event handlers as well. If you want to trigger a full cleanup of an element, change: ```js elem.removeData(); ``` to: ```js angular.element.cleanData([elem]); ``` In most cases, though, cleaning up after an element is supposed to be done only when it's removed from the DOM as well; in such cases the following: ```js elem.remove(); ``` will remove event handlers as well.
mgol
added a commit
to mgol/angular.js
that referenced
this issue
Mar 27, 2018
This change aligns jqLite with jQuery. Fixes angular#15869 BREAKING CHANGE: Before this commit `removeData()` invoked on an element removed its event handlers as well. If you want to trigger a full cleanup of an element, change: ```js elem.removeData(); ``` to: ```js angular.element.cleanData(elem); ``` In most cases, though, cleaning up after an element is supposed to be done only when it's removed from the DOM as well; in such cases the following: ```js elem.remove(); ``` will remove event handlers as well.
mgol
added a commit
to mgol/angular.js
that referenced
this issue
Mar 28, 2018
This change aligns jqLite with jQuery. Fixes angular#15869 BREAKING CHANGE: Before this commit `removeData()` invoked on an element removed its event handlers as well. If you want to trigger a full cleanup of an element, change: ```js elem.removeData(); ``` to: ```js angular.element.cleanData(elem); ``` In most cases, though, cleaning up after an element is supposed to be done only when it's removed from the DOM as well; in such cases the following: ```js elem.remove(); ``` will remove event handlers as well.
mgol
added a commit
to mgol/angular.js
that referenced
this issue
Mar 28, 2018
This change aligns jqLite with jQuery. Fixes angular#15869 BREAKING CHANGE: Before this commit `removeData()` invoked on an element removed its event handlers as well. If you want to trigger a full cleanup of an element, change: ```js elem.removeData(); ``` to: ```js angular.element.cleanData(elem); ``` In most cases, though, cleaning up after an element is supposed to be done only when it's removed from the DOM as well; in such cases the following: ```js elem.remove(); ``` will remove event handlers as well.
mgol
added a commit
to mgol/angular.js
that referenced
this issue
Mar 28, 2018
This change aligns jqLite with jQuery. Fixes angular#15869 BREAKING CHANGE: Before this commit `removeData()` invoked on an element removed its event handlers as well. If you want to trigger a full cleanup of an element, change: ```js elem.removeData(); ``` to: ```js angular.element.cleanData(elem); ``` In most cases, though, cleaning up after an element is supposed to be done only when it's removed from the DOM as well; in such cases the following: ```js elem.remove(); ``` will remove event handlers as well.
mgol
added a commit
that referenced
this issue
Apr 3, 2018
This change aligns jqLite with jQuery. Fixes #15869 Closes #16512 BREAKING CHANGE: Before this commit `removeData()` invoked on an element removed its event handlers as well. If you want to trigger a full cleanup of an element, change: ```js elem.removeData(); ``` to: ```js angular.element.cleanData(elem); ``` In most cases, though, cleaning up after an element is supposed to be done only when it's removed from the DOM as well; in such cases the following: ```js elem.remove(); ``` will remove event handlers as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a ...
Current behavior:
jqLite#removeDatacurrently:Expected / new behavior:
The second behavior is incorrect; the only data touched should be user-provided data, i.e. those set via
elem.data(key, value). That's how jQuery behaves.If complete deallocation of event handlers is required as well, one can use:
Note that currently
jqLite.cleanDatadefers tojqLiteRemoveDataunder the hood so its implementation will have to be changed whenjqLiteRemoveDatais fixed.Minimal reproduction of the problem with instructions:
AngularJS + jqLite (handler removed): http://plnkr.co/edit/XBw30umyz68UnERE9LyS?p=preview
AngularJS + jQuery (handler not removed): http://plnkr.co/edit/sdo9ShVA66yuEIIEvlII?p=preview
Angular version: 1.x.y
1.6.3, snapshot as well
Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
All
Anything else:
This will require a breaking change in jqLite. Setting to 1.7.0.
The text was updated successfully, but these errors were encountered: