Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(angular-loader): do not depend on "closure" globals that are not available in angular-loader #15880

Closed
1 of 3 tasks
gkalpak opened this issue Apr 2, 2017 · 0 comments
Closed
1 of 3 tasks

fix(angular-loader): do not depend on "closure" globals that are not available in angular-loader #15880

gkalpak opened this issue Apr 2, 2017 · 0 comments
Labels
component: misc core frequency: low severity: broken expected use type: bug
Milestone
Backlog - won't fix

Comments

@gkalpak
Copy link
Member

gkalpak commented Apr 2, 2017

I'm submitting a ...

  • bug report
  • feature request
  • other (Please do not submit support requests here (see above))

Current behavior:
Commits such as cf43ccd and a0641ea (possibly others) have changed stringify.js in ways that do not take into account the fact that it is also included in angular-loader where it does not have access to all th necessary "closure" globals available in angular.js.
Fortunately, this bug only appears when there are errors to be thrown.

Expected / new behavior:
Files that are included in angular-loader should not break by trying to access properties/functions that are not available in angular-loader.

Angular version: At least 1.3.3+

Browser: all
gkalpak added a commit to gkalpak/angular.js that referenced this issue Apr 2, 2017
@gkalpak
fix(angular-loader): do not depend on "closure" globals that may not …
59dbff0 
…be available

Code that is distributed as part of both `angular.js` and `angular-loader.js`
should not depend on "closure" globals that may not be available in
`angular-loader`.

Fixes angular#15880
@gkalpak gkalpak mentioned this issue Apr 2, 2017
Closed
3 tasks
@gkalpak gkalpak added this to the Backlog milestone Apr 2, 2017
gkalpak added a commit to gkalpak/angular.js that referenced this issue Apr 27, 2017
@gkalpak
fix(angular-loader): do not depend on "closure" globals that may not …
4c0c834 
…be available

Code that is distributed as part of both `angular.js` and `angular-loader.js`
should not depend on "closure" globals that may not be available in
`angular-loader`.

Fixes angular#15880
gkalpak added a commit that referenced this issue Apr 27, 2017
@gkalpak
fix(angular-loader): do not depend on "closure" globals that may not …
a3226d0 
…be available

Code that is distributed as part of both `angular.js` and `angular-loader.js`
should not depend on "closure" globals that may not be available in
`angular-loader`.

Fixes #15880

Closes #15881
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: misc core frequency: low severity: broken expected use type: bug
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging a pull request may close this issue.

fix(angular-loader): do not depend on "closure" globals that may not be available gkalpak/angular.js
1 participant
@gkalpak