Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

uibModal won't open #16594

Closed
2 tasks
scottcwilliams511 opened this issue Jun 8, 2018 · 6 comments · Fixed by angular-indonesia/angular.js#150 or javascript-indonesias/angular.js#95
Closed
2 tasks
Assignees
Milestone

Comments

@scottcwilliams511
Copy link

I'm submitting a ...

  • [x ] bug report
  • feature request
  • other

Current behavior:

Clicking a button which opens a modal results in this error: "TypeError: u is not a function".

Expected / new behavior:

Usually the Modal opens and displays its contents fine. Reverting to AngularJS 1.7.0 makes this error go away.

Minimal reproduction of the problem with instructions:

AngularJS version: 1.7.1

Browser: [all | Chrome XX | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Anything else:

In the minified file it takes me to

.provider("$uibModal", function() {
...
    angular.extend(c, {
     $resolve: l.$scope.$resolve
      }, r)),
     c = u(),    // This line
     angular.isFunction(c.$onInit) && c.$onInit()),
     s.open(

So I'd like to believe a change from 1.7.0 to 1.7.1 around here caused the bug.

@thorn0
Copy link
Contributor

thorn0 commented Jun 8, 2018

They used a private API that was removed in #16580.

@frederikprijck
Copy link
Contributor

frederikprijck commented Jun 11, 2018

You probably wanna open an issue at https://github.com/angular-ui/bootstrap, it might be a good idea to refer to the links provided by @thorn0

@gkalpak
Copy link
Member

gkalpak commented Jun 11, 2018

We discussed this and it seems that this clean-up will cause unnecessary pain for several developers (that depend on popular UI libraries, such as ngMaterial and ui-bootstrap - probably others too).

So, despite this being an internal API, we decided to revert the change in 1.7.2 (sorry @thorn0 😁).

@gkalpak gkalpak added this to the 1.7.x milestone Jun 11, 2018
@gkalpak gkalpak self-assigned this Jun 11, 2018
gkalpak added a commit to gkalpak/angular.js that referenced this issue Jun 11, 2018
This reverts commit 8e104ee.

This internal clean-up turned out to break popular UI libraries (e.g.
`ngMaterial`, `ui-bootstrap`) and cause pain to developers.

Fixes angular#16594
gkalpak added a commit that referenced this issue Jun 11, 2018
This reverts commit 8e104ee.

This internal clean-up turned out to break popular UI libraries (e.g.
`ngMaterial`, `ui-bootstrap`) and cause pain to developers.

Fixes #16594

Closes #16595
@egamboa
Copy link

egamboa commented Jun 12, 2018

ty

@gkalpak
Copy link
Member

gkalpak commented Jun 12, 2018

FYI, v1.7.2 has been released.

@icfantv
Copy link

icfantv commented Jun 14, 2018

@gkalpak on behalf of the no-longer-maintained AngularJS ui-bootstrap library, thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants