This repository was archived by the owner on Apr 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 27.4k
uibModal won't open #16594
Closed
2 tasks
scottcwilliams511 opened this issue
Jun 8, 2018
· 6 comments
· Fixed by angular-indonesia/angular.js#150 or javascript-indonesias/angular.js#95
Closed
2 tasks
uibModal won't open #16594
scottcwilliams511 opened this issue
Jun 8, 2018
· 6 comments
· Fixed by angular-indonesia/angular.js#150 or javascript-indonesias/angular.js#95
Milestone
Comments
They used a private API that was removed in #16580. |
|
We discussed this and it seems that this clean-up will cause unnecessary pain for several developers (that depend on popular UI libraries, such as So, despite this being an internal API, we decided to revert the change in 1.7.2 (sorry @thorn0 😁). |
gkalpak
added a commit
to gkalpak/angular.js
that referenced
this issue
Jun 11, 2018
This reverts commit 8e104ee. This internal clean-up turned out to break popular UI libraries (e.g. `ngMaterial`, `ui-bootstrap`) and cause pain to developers. Fixes angular#16594
This was referenced Jun 12, 2018
3 tasks
ty |
FYI, v1.7.2 has been released. |
@gkalpak on behalf of the no-longer-maintained AngularJS ui-bootstrap library, thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a ...
Current behavior:
Clicking a button which opens a modal results in this error: "TypeError: u is not a function".
Expected / new behavior:
Usually the Modal opens and displays its contents fine. Reverting to AngularJS 1.7.0 makes this error go away.
Minimal reproduction of the problem with instructions:
AngularJS version: 1.7.1
Browser: [all | Chrome XX | Firefox XX | Edge XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
Anything else:
In the minified file it takes me to
So I'd like to believe a change from 1.7.0 to 1.7.1 around here caused the bug.
The text was updated successfully, but these errors were encountered: