You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
In src/ng/browser.js there's a reference to lastCookies.length:
if (lastCookies.length > 20) {
$log.warn("Cookie '"+ name +"' possibly not set or overflowed because too many cookies " +
"were already set (" + lastCookies.length + " > 20 )");
}
However, lastCookies is an Object and Objects do not have a length property, so this if statement will never be triggered.
The text was updated successfully, but these errors were encountered:
correct. this is a bug. looks like when I wrote this, I didn't finish the test and the unfinished test made it look like this feature was implemented correctly. my fault.
the warning is defunct (and the test is incorrect) so obviously nobody is using
it and it just takes up space.
also the browser behavior varies (ff and chrome allow up to 150 cookies, safari
even more), so it's not very useful.
Closes#1712
jamessharp
pushed a commit
to jamessharp/angular.js
that referenced
this issue
Jan 18, 2013
the warning is defunct (and the test is incorrect) so obviously nobody is using
it and it just takes up space.
also the browser behavior varies (ff and chrome allow up to 150 cookies, safari
even more), so it's not very useful.
Closesangular#1712
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In src/ng/browser.js there's a reference to lastCookies.length:
However, lastCookies is an Object and Objects do not have a length property, so this if statement will never be triggered.
The text was updated successfully, but these errors were encountered: