$q .always() Implementation

[MandarinConLaBarba]

I know the goal is to keep $q lightweight, but any interest in an 'always' callback facility? Either an additional arg in .then()

.then(successCallback, errorCallback, alwaysCallback)

Or something like:

.then(callback).always(callback)

[groner]

+1

The upstream q package calls this .fin()

[latentflip]

Is this issue a duplicate of #1378, if so can we move discussion there and close this one maybe? 👍

[groner]

They're different. The .fin() method is supposed to be like a finally block. The .end() method is a mechanism to say I'm done with this, if I missed something please treat it as an unhandled exception (log it, use $exceptionHandler, incite a riot).

[latentflip]

Oops, my bad. As you were :)
On 29 Jan 2013 22:04, "Kai Groner" notifications@github.com wrote:

They're different. The .fin() method is supposed to be like a finally
block. The .end() method is a mechanism to say I'm done with this, if I
missed something please treat it as an unhandled exception (log it, use
$exceptionHandler, incite a riot).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1828#issuecomment-12860978.

[maxbates]

+1

[L42y]

duplicate of #2424?

[MikeMcElroy]

Does this make sense with promise chaining? promise.then(callback).always(callback).then(callback again?)

[petebacondarwin]

Yes. It is semantically equivalent to simply providing the same handler for
both parameters of the then() function.

Pete
...from my mobile.
On May 8, 2013 2:32 PM, "MikeMcElroy" notifications@github.com wrote:

Does this make sense with promise chaining?
promise.then(callback).always(callback).then(callback again?)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1828#issuecomment-17605575
.

[MikeMcElroy]

Provided that callback has no dependencies on what information it receives,
or the resolved promise passed the same information as the rejected promise?

On Wed, May 8, 2013 at 9:16 AM, Pete Bacon Darwin
notifications@github.comwrote:

Yes. It is semantically equivalent to simply providing the same handler
for
both parameters of the then() function.

Pete
...from my mobile.
On May 8, 2013 2:32 PM, "MikeMcElroy" notifications@github.com wrote:

Does this make sense with promise chaining?
promise.then(callback).always(callback).then(callback again?)

—
Reply to this email directly or view it on GitHub<
https://github.com/angular/angular.js/issues/1828#issuecomment-17605575>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1828#issuecomment-17616548
.

[groner]

An always/finally callback receives no arguments and it resolves to same as the original promise unless it rejects.

    // Resolves to 5
    $q.when(5).always(function() { return 7 });

    // Resolves to 5 after 1 second
    $q.when(5).always(q.delay(1000) { return 7 });

    // Rejects with Error: nowayjose
    $q.when(5).always(function() { throw new Error('nowayjose') });

See https://github.com/kriskowal/q/wiki/API-Reference#promisefinallycallback.

[petebacondarwin]

@groner - yes, sorry, you are absolutely right here.

By the way this is already in: #2424 - landed in master at 6605adf