html5Mode appbase regression in 1.1.5

[clkao]

I noticed that 58ef323 introduced html5Mode behaviour changes for determining appbase.

With html5Mode, given an app http://foo/, and a deep link url http://foo/bar/baz that can be reached with ng-href or something within the application, the appbase is /. However if the user goes to http://foo/bar/baz directly, the appbase becomes http://foo/bar, leaving the $$path to be /baz, and this breaks url router or ui-router.

[tomchentw]

Encounter same problem here. How can I fix this?
Say, my ng-app root at '/', but I still want 'foo/bar' to be deeply linked. But currently it can't.
Only path 'foo/:id' can be linked.

Is this behavior normal?

[jeme]

Let me just see if I understand this correct...

If you go to: http://domain.com/ the app base is /... then you start browsing the page and goes to /path then on to /path/here/5 then if you hit refresh here, the app base is now /path/here ??

If that is the case, then this sounds like a severe error, and not just a behavior change... A changing App base is going to be horrible to work with? o.O...

[clkao]

@jeme yes that's right. I changed the summary to 'regression' which should now sound more severe than behaviour change ;)

[tomchentw]

@jeme Yes. But what do you mean that's a server error?

[jeme]

@tomchentw Severe Error, Severe Bug, Severe Issue... And because that if you take my scenario, navigating to a "child" url inside an angular application or going directly to it though an external links leaves it in 2 different states, this is likely to break any existing angular app that uses HTML 5, not to mention how hard and illogical Html5 mode would behave...

I would expect the 2 scenarios where:

a. By Nav

1. Open http://domain.com/ => base = '/', path= '/'
2. Navigate to /path/here/5 => base = '/', path= '/path/here/5' (Url is now http://domain.com/path/here/5)

b. By Direct

1. Open http://domain.com/path/here/5 => base = '?', path= '?'

I would expect B to be base = '/', path= '/path/here/5' where it sounds like its: base = '/path/here', path= '/5' which creates a complete different behavior.

Html 5 already present us with an option to define base path: http://www.w3schools.com/tags/tag_base.asp, alternatively let the $locationProvider have a setBasePath... Angular shouldn't try to infer this from the initial URL, as that will just cause trouble.

[tomchentw]

@jeme Your expect of B is what I think. Would this problem be solved if Angular can find appBaseUrl using base tag?
BTW, it's strange for me that http://domain.com/user/:id works but not http://domain.com/users/info.

[clkao]

adding <base href="/"> restores the original behaviour and makes ui-router work properly again.

This seems to be a saner default.

[chuckd]

@clkao that fix doesn't work for us - if I set the base href then all the relatives links break. Would work if we switched to absolute links though.

[frederic-bonjour]

Same problem for me: routing is broken after switching from 1.1.4 to 1.1.5 :(
I already have a <base href="..."/> which is not set to /, but to a different value (like http://server/path/), and 1.1.5 does not work.

Any suggestion to avoid this issue while keeping 1.1.5?
Thanks a lot!

[frederic-bonjour]

I found what breaks my routing process:
2c69a67#L1R530

I'm using jstree and it preventDefault() on links. In AngularJS 1.1.5, they now check if the event isDefaultPrevented...

I just have to find how to make them work together :)

[richardcrichardc]

I can't see html5 mode working with page refreshes unless the app base is independent of the url the page was loaded on. Having the app base coming from the base tag doesn't work as it means relative links will not work.

To be clear by app base I mean the path that '/' is relative to in the router.

I would say app base should either default to '/' or have no default, you need to set the app base to activate HTML5 mode.

[wcandillon]

@richardcrichardc I agree.
With 1.1.5, I had to set my app base to '/' explicitly.