Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

angular.equals({}, []) == true #2851

Closed
appsforartists opened this issue Jun 2, 2013 · 1 comment
Closed

angular.equals({}, []) == true #2851

appsforartists opened this issue Jun 2, 2013 · 1 comment

Comments

@appsforartists
Copy link
Contributor

angular.equals({}, []) is returning true. angular.equals([], {}) is returning false.
@appsforartists appsforartists mentioned this issue Jun 2, 2013
Closed
appsforartists added a commit to Versal/angular.js that referenced this issue Jun 5, 2013
@appsforartists
fix(equals): {} and [] should not be considered equalivalent
7962787 
angular.equals was returning inconsistent values for the comparison between
{} and []:

    angular.equals({}, []) // true
    angular.equals([], {}]) // false

Since these object are not of the same type, they should not be considered
equivalent.

Fixes angular#2851.
@btford btford closed this as completed Aug 24, 2013
@btford
Copy link
Contributor

btford commented Aug 24, 2013

As part of our effort to clean out old issues, this issue is being automatically closed since it has been inactivite for over two months.

Please try the newest versions of Angular (1.0.8 and 1.2.0-rc.1), and if the issue persists, comment below so we can discuss it.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(equals): {} and [] should not be considered equivalent Versal/angular.js
2 participants
@btford @appsforartists