Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

LocationHashbangUrl duplicates query params in v1.1.5 #2898

Closed
ospatil opened this issue Jun 7, 2013 · 5 comments
Closed

LocationHashbangUrl duplicates query params in v1.1.5 #2898

ospatil opened this issue Jun 7, 2013 · 5 comments

Comments

@ospatil
Copy link

ospatil commented Jun 7, 2013

I have an application in which $location uses default (hashbang) mode and the base URL is something like - http://myserver.com:8080/?appStage=D. The application was upgraded to Angular 1.1.5 last week. Since then, when I enter the above url in the browser location bar I observe that the query params are getting duplicated like this - http://myserver.com:8080/?appStage=D#/welcome?appStage=D.

I have done some investigation and have created two test-cases. Here is a code of the test cases - https://gist.github.com/ospatil/5728023. These test-cases can be copied into "HashbangUrl" suite of locationSpec.js and run. The first that uses LocationHashbangUrl fails but second that uses the same url but works with LocationHtml5Url passes.

@josebalius
Copy link

I can also repot the same thing happening to me, we put it Angular v1.1.5 last week to do a trial run and notice that our server query params seem to duplicate on every page

http://myurl.com/home/welcome?token=1234 turns into

http://myurl.com/home/welcome?token=1234#/welcome?ctoken=1234

Is there anyway to prevent this?

@chrisirhc
Copy link
Contributor

Also causes this redirect when ngInclude is used ( #2868 ).

@vitalets
Copy link

Also having this issue!

@nelsonpecora
Copy link

This is happening in 1.2.14 in hashbang mode, but isn't happening in html5 mode. In html5 mode, though, when loading a page that is outside of the baseurl, I'm getting an angularJS error (I think the error is in parseAppUrl() in angular.js:8678, but I'm not 100% sure).

@jeffbcross jeffbcross added this to the 1.3.0 milestone Mar 27, 2014
@btford btford removed the gh: issue label Aug 20, 2014
@IgorMinar
Copy link
Contributor

I believe that this was already fix in one of the 1.3 betas. the tests provided now pass. closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants